Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(240)

Issue 6186044: [PATCH] libgcov support for profile collection in region of interest

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by tejohnson
Modified:
9 years, 10 months ago
Reviewers:
davidxl, hubicka
CC:
gcc-patches_gcc.gnu.org
Base URL:
svn+ssh://gcc.gnu.org/svn/gcc/trunk/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : [PATCH] libgcov support for profile collection in region of interest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -26 lines) Patch
M gcc/doc/gcov.texi View 1 1 chunk +6 lines, -0 lines 0 comments Download
M gcc/gcov-io.h View 1 chunk +6 lines, -0 lines 0 comments Download
M libgcc/Makefile.in View 1 1 chunk +1 line, -1 line 0 comments Download
M libgcc/libgcov.c View 1 6 chunks +80 lines, -25 lines 0 comments Download

Messages

Total messages: 7
tejohnson
This patch adds functionality to libgcov to enable user applications to collect profile data only ...
12 years, 2 months ago (2012-05-03 17:52:55 UTC) #1
davidxl
+Honza and Nathan. David On Thu, May 3, 2012 at 10:52 AM, Teresa Johnson <tejohnson@google.com> ...
12 years, 2 months ago (2012-05-07 16:06:44 UTC) #2
hubicka_ucw.cz
> +Honza and Nathan. > > David > > On Thu, May 3, 2012 at ...
12 years, 2 months ago (2012-05-07 23:36:57 UTC) #3
tejohnson
Hi Honza, I added L_gcov_reset and L_gcov_dump for the new interfaces, and also added a ...
12 years, 2 months ago (2012-05-08 13:40:27 UTC) #4
hubicka_ucw.cz
> Hi Honza, > > I added L_gcov_reset and L_gcov_dump for the new interfaces, and ...
12 years, 2 months ago (2012-05-08 17:37:38 UTC) #5
tejohnson
On Tue, May 8, 2012 at 10:37 AM, Jan Hubicka <hubicka@ucw.cz> wrote: > > > ...
12 years, 2 months ago (2012-05-08 18:39:46 UTC) #6
hubicka_ucw.cz
12 years, 2 months ago (2012-05-08 19:08:33 UTC) #7
> On Tue, May 8, 2012 at 10:37 AM, Jan Hubicka <hubicka@ucw.cz> wrote:
> >
> > > Hi Honza,
> > >
> > > I added L_gcov_reset and L_gcov_dump for the new interfaces, and also
> > > added a description into the gcov man page. Let me know if it looks
> > > ok now.
> > >
> > > Bootstrapped and tested on x86_64-unknown-linux-gnu.
> > >
> > > Thanks,
> > > Teresa
> > >
> > > 2012-05-08   Teresa Johnson  <tejohnson@google.com>
> > >
> > >       * libgcc/libgcov.c (gcov_clear, __gcov_reset): New functions.
> > >       (__gcov_dump): Ditto.
> > >       (gcov_dump_complete): New global variable.
> > >       (__gcov_flush): Outline functionality now in gcov_clear.
> > >       * gcc/gcov-io.h (__gcov_reset, __gcov_dump): Declare.
> > >       * libgcc/Makefile.in (L_gcov_reset, L_gcov_dump): Define.
> > >       * gcc/doc/gcov.texi: Add note on using __gcov_reset and
__gcov_dump.
> >
> > It seems OK now, though gcov_clear will end up being in both gcov_reset and
gcov_flush,
> > but I suppose it is short enough to make this issue mood
> > (otherwise we could make it hidden exported from gcov_flush psection)
> >
> > Honza
> 
> The same issue is going to exist with gcov_exit and gcov_dump/gcov_flush, and
> with gcov_dump_complete. I agree that it seems cleaner to export them hidden
> so I have done that. Bootstrapped and re-testing is in progress. Ok for trunk
> assuming regression tests pass? New patch is below.
OK,
thanks
Honza
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b