Issue 6182046: implement open-port and close-port

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by fwereade

Modified:
11 years, 11 months ago

Reviewers:
mp+104576

Visibility:
Public.

Description

implement open-port and close-port (plus mild deduplication in tests) https://code.launchpad.net/~fwereade/juju/go-open-close-port-commands/+merge/104576 Requires: https://code.launchpad.net/~fwereade/juju/go-unit-get-command/+merge/104537 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : implement open-port and close-port #

Patch Set 3 : implement open-port and close-port #

Patch Set 4 : implement open-port and close-port #

Total comments: 6

Patch Set 5 : implement open-port and close-port #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+211 lines, -28 lines)			Patch
A	[revision details]	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/jujuc/server/config-get_test.go	View	1 2 3 4	1 chunk	+2 lines, -12 lines	0 comments	Download
M	cmd/jujuc/server/context.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/jujuc/server/context_test.go	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
A	cmd/jujuc/server/ports.go	View	1 2 3 4	1 chunk	+100 lines, -0 lines	0 comments	Download
A	cmd/jujuc/server/ports_test.go	View	1 2	1 chunk	+86 lines, -0 lines	0 comments	Download
M	cmd/jujuc/server/unit-get_test.go	View	1 2 3 4	1 chunk	+2 lines, -12 lines	0 comments	Download
M	cmd/jujuc/server/util_test.go	View	1 2 3 4	1 chunk	+12 lines, -0 lines	0 comments	Download
M	cmd/supercommand.go	View	1 2 3 4	1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

niemeyer

LGTM, good stuff. Just a couple of suggestions to simplify a bit the New functions. ...

11 years, 11 months ago (2012-05-17 19:40:59 UTC) #5

fwereade

11 years, 11 months ago (2012-05-18 09:53:52 UTC) #6

*** Submitted:

implement open-port and close-port

(plus mild deduplication in tests)

R=niemeyer
CC=
https://codereview.appspot.com/6182046

https://codereview.appspot.com/6182046/diff/8001/cmd/jujuc/server/ports.go
File cmd/jujuc/server/ports.go (right):

https://codereview.appspot.com/6182046/diff/8001/cmd/jujuc/server/ports.go#ne...
cmd/jujuc/server/ports.go:77: info: func() *cmd.Info {
On 2012/05/17 19:41:00, niemeyer wrote:
> Global:
> 
>     var openPortInfo = &cmd.Info{
>         ...
>     }
> 
> Within New:
> 
>      info: openPortInfo,
> 
> Then change Info to return it rather than calling it.

Done.

https://codereview.appspot.com/6182046/diff/8001/cmd/jujuc/server/ports.go#ne...
cmd/jujuc/server/ports.go:83: action: func(unit *state.Unit, protocol string,
port int) error {
On 2012/05/17 19:41:00, niemeyer wrote:
> action: (*state.Unit).OpenPort,
> 
> Works without any other changes. (!!)

Whoa! Cool! Done.

Expand All Messages | Collapse All Messages