Issue 61820043: provider/local: qualify pkill jujud with home dir

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 61820043: provider/local: qualify pkill jujud with home dir

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by axw

Modified:
10 years, 2 months ago

Reviewers:
dimitern, mp+205717

Visibility:
Public.

Description

provider/local: qualify pkill jujud with home dir When local was changed to use common code for bootstrap and destroy, destroy regressed and would destroy any jujud running on the machine. This CL fixes it by only killing the jujud that is located in the environment's data-dir. https://code.launchpad.net/~axwalk/juju-core/local-pkill-qualified-path/+merge/205717 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	provider/local/environ.go	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

dimitern

10 years, 2 months ago (2014-02-13 09:32:42 UTC) #2

LGTM, assuming you tested this with a live environment.

Expand All Messages | Collapse All Messages