Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(185)

Issue 6180045: minor playground UI changes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years ago by felix8a
Modified:
14 years ago
Reviewers:
Jasvir, metaweta
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

1. build.xml has a rule to check if the playground needs to be rebuilt. The rule doesn't look at all relevant files. 2. tweak button layout.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -25 lines) Patch
M build.xml View 1 chunk +1 line, -2 lines 2 comments Download
M src/com/google/caja/demos/playground/client/ui/PlaygroundUI.ui.xml View 2 chunks +25 lines, -23 lines 0 comments Download

Messages

Total messages: 4
felix8a
14 years ago (2012-05-03 21:39:59 UTC) #1
Jasvir
http://codereview.appspot.com/6180045/diff/1/build.xml File build.xml (right): http://codereview.appspot.com/6180045/diff/1/build.xml#newcode1228 build.xml:1228: <srcfiles dir="${src.caja}/demos/playground" includes="**/*.xml"/> Hmm What file was missed by ...
14 years ago (2012-05-03 21:44:50 UTC) #2
felix8a
http://codereview.appspot.com/6180045/diff/1/build.xml File build.xml (right): http://codereview.appspot.com/6180045/diff/1/build.xml#newcode1228 build.xml:1228: <srcfiles dir="${src.caja}/demos/playground" includes="**/*.xml"/> On 2012/05/03 21:44:50, Jasvir wrote: > ...
14 years ago (2012-05-03 21:48:32 UTC) #3
Jasvir
14 years ago (2012-05-03 21:50:46 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b