Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1259)

Issue 61520046: code review 61520046: ogle/probe: update linux/amd64 magic arena_foo_offset c... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 9 months ago by nigeltao
Modified:
7 years, 9 months ago
Reviewers:
r
CC:
r
Visibility:
Public.

Description

ogle/probe: update linux/amd64 magic arena_foo_offset constants. They were determined by inserting into pkg/runtime: runtime·printf("arena_start_offset=%d\n", (uint64)(&runtime·mheap.arena_start) - (uint64)(&runtime·mheap)); $ go version go version devel +72ef9cff4fa9 Mon Feb 10 20:27:31 2014 -0500 linux/amd64

Patch Set 1 #

Patch Set 2 : diff -r 239d84d9b130 https://code.google.com/p/ogle #

Patch Set 3 : diff -r 239d84d9b130 https://code.google.com/p/ogle #

Patch Set 4 : diff -r 239d84d9b130 https://code.google.com/p/ogle #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M probe/probe_linux_amd64.s View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3
nigeltao
Hello r@golang.org, I'd like you to review this change to https://code.google.com/p/ogle
7 years, 9 months ago (2014-02-12 00:29:13 UTC) #1
r
LGTM
7 years, 9 months ago (2014-02-12 00:33:55 UTC) #2
nigeltao
7 years, 9 months ago (2014-02-12 00:38:37 UTC) #3
*** Submitted as https://code.google.com/p/ogle/source/detail?r=b3f4d2b8af30 ***

ogle/probe: update linux/amd64 magic arena_foo_offset constants.

They were determined by inserting into pkg/runtime:
runtime·printf("arena_start_offset=%d\n",
(uint64)(&runtime·mheap.arena_start) - (uint64)(&runtime·mheap));

$ go version
go version devel +72ef9cff4fa9 Mon Feb 10 20:27:31 2014 -0500 linux/amd64

LGTM=r
R=r
https://codereview.appspot.com/61520046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b