Issue 61510051: Support for juju core constraints

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 61510051: Support for juju core constraints

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by bac

Modified:
10 years, 2 months ago

Reviewers:
frankban, mp+206006

Visibility:
Public.

Description

Support for juju core constraints All juju core constraints should be supported by Juju GUI. See https://juju.ubuntu.com/docs/reference-constraints.html The 'tags' constraint was not implemented as it is only supported for MaaS deployments. https://code.launchpad.net/~bac/charms/precise/juju-gui/support-constraints/+merge/206006 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Support for juju core constraints #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -1 line)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	server/guiserver/bundles/utils.py	View	1	1 chunk	+15 lines, -1 line	0 comments	Download
M	server/guiserver/tests/bundles/test_utils.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

frankban

LGTM with just a minor comment. Thank you! https://codereview.appspot.com/61510051/diff/1/server/guiserver/bundles/utils.py File server/guiserver/bundles/utils.py (right): https://codereview.appspot.com/61510051/diff/1/server/guiserver/bundles/utils.py#newcode49 server/guiserver/bundles/utils.py:49: Could ...

10 years, 2 months ago (2014-02-12 17:36:42 UTC) #2

bac

10 years, 2 months ago (2014-02-12 19:15:55 UTC) #4

*** Submitted:

Support for juju core constraints

All juju core constraints should be supported by Juju GUI.
See https://juju.ubuntu.com/docs/reference-constraints.html
The 'tags' constraint was not implemented as it is only supported for MaaS
deployments.

R=frankban
CC=
https://codereview.appspot.com/61510051

Expand All Messages | Collapse All Messages