Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(10292)

Issue 6148044: Backported r187026 from branches/google/gcc-4_6

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by asharif
Modified:
11 years, 12 months ago
Reviewers:
shenhan, jingyu, carrot
CC:
bjanakiraman_google.com, gcc-patches_gcc.gnu.org
Base URL:
svn+ssh://gcc.gnu.org/svn/gcc/branches/google/gcc-4_6_3-mobile/
Visibility:
Public.

Description

PTAL at this patch. 2012-03-12 Richard Guenther <rguenther@suse.de> * gthr.h (__GTHREAD_MUTEX_INIT_FUNCTION): Adjust specification. * gthr-posix.h (__GTHREAD_MUTEX_INIT_FUNCTION): Define. (__gthread_mutex_init_function): New function. * gthr-single.h (__GTHREAD_MUTEX_INIT_FUNCTION): Define. PR gcov/49484 * libgcov.c: Include gthr.h. (__gcov_flush_mx): New global variable. (init_mx, init_mx_once): New functions. (__gcov_flush): Protect self with a mutex. (__gcov_fork): Re-initialize mutex after forking. * unwind-dw2-fde.c: Change condition under which to use __GTHREAD_MUTEX_INIT_FUNCTION. Testing: Built all of ChromeOS with this compiler successfully. Built bootstrap crosstool with and without the patch and found no regressions.

Patch Set 1 #

Patch Set 2 : Added description in changelog. #

Patch Set 3 : Added missing newline. #

Patch Set 4 : Addressed issues. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -9 lines) Patch
M . View 0 chunks +0 lines, -0 lines 0 comments Download
M gcc/ChangeLog.google-4_6 View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M gcc/gthr.h View 1 chunk +5 lines, -4 lines 0 comments Download
M gcc/gthr-posix.h View 2 chunks +8 lines, -0 lines 0 comments Download
M gcc/gthr-single.h View 1 chunk +1 line, -0 lines 0 comments Download
M gcc/libgcov.c View 5 chunks +31 lines, -1 line 0 comments Download
M gcc/unwind-dw2-fde.c View 2 chunks +1 line, -4 lines 0 comments Download
M libgcc/ChangeLog View 1 chunk +16 lines, -0 lines 0 comments Download
M libgcc/ChangeLog.google-4_6 View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 5
asharif
This patch fixes a profile collection issue we see when profiling Chrome.
12 years ago (2012-05-01 21:51:04 UTC) #1
asharif
+carrot@
12 years ago (2012-05-01 22:40:12 UTC) #2
jingyu
1) Please add an description entry to libgcc/ChangeLog.google-4_6 2) Your gcc/ChangeLog.google-4_6 change reverts someone else's ...
12 years ago (2012-05-01 22:51:22 UTC) #3
asharif
On 2012/05/01 22:51:22, jingyu wrote: > 1) Please add an description entry to libgcc/ChangeLog.google-4_6 Done. ...
11 years, 12 months ago (2012-05-02 18:24:24 UTC) #4
jingyu
11 years, 12 months ago (2012-05-02 20:30:57 UTC) #5
LGTM

On Wed, May 2, 2012 at 11:24 AM,  <asharif@chromium.org> wrote:
> On 2012/05/01 22:51:22, jingyu wrote:
>>
>> 1) Please add an description entry to libgcc/ChangeLog.google-4_6
>
>
> Done.
>
>
>
>> 2) Your gcc/ChangeLog.google-4_6 change reverts someone else's change.
>
> Please
>>
>> update it and also update the time of your entry.
>
>
> Done.
>
>
>
>> 3) Please list in the Description field what tests you have done.
>
>
> Done.
>
>
>> Thanks,
>> Jing
>
>
>> On 2012/05/01 22:40:12, asharif wrote:
>> > +carrot@
>
>
>
>
> http://codereview.appspot.com/6148044/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b