Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1218)

Issue 6137050: Doc: NR clarified \footnote command as a TextScript (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 2 months ago by pkx166h
Modified:
5 years, 9 months ago
Reviewers:
Keith, dak, carl.d.sorensen, Trevor Daniels, Graham Percival, t.daniels, Jean-Charles
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc: NR clarified \footnote command as a TextScript While chorded notes *require* the \footnote command attached as a TextScript, normal notes can _also_ be attached like that. The original description stated the command *must* come before single notes.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Second patch with Trevor's suggestions #

Patch Set 3 : changes to examples and text for '<>\footnote' #

Total comments: 17

Patch Set 4 : Corrections spotted by David. Will require one more patch - see comments #

Total comments: 18

Patch Set 5 : Corrections for \breathe. More text corrs. Thanks Keith. Added @cindexes too. #

Total comments: 15

Patch Set 6 : More corrections to syntax and grammar. Thanks Keith and JCM #

Total comments: 4

Patch Set 7 : More minor corrections (thanks Graham). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -100 lines) Patch
M Documentation/notation/input.itely View 1 2 3 4 5 6 4 chunks +92 lines, -100 lines 0 comments Download

Messages

Total messages: 23
Graham Percival
http://codereview.appspot.com/6137050/diff/1/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/6137050/diff/1/Documentation/notation/input.itely#newcode1050 Documentation/notation/input.itely:1050: footnote is being attached but can also be attached ...
6 years, 2 months ago (2012-04-30 07:39:21 UTC) #1
pkx166h
http://codereview.appspot.com/6137050/diff/1/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/6137050/diff/1/Documentation/notation/input.itely#newcode1050 Documentation/notation/input.itely:1050: footnote is being attached but can also be attached ...
6 years, 2 months ago (2012-05-02 06:01:46 UTC) #2
Trevor Daniels
Hi James Alternative text suggested. Trevor http://codereview.appspot.com/6137050/diff/1/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/6137050/diff/1/Documentation/notation/input.itely#newcode1050 Documentation/notation/input.itely:1050: footnote is being ...
6 years, 2 months ago (2012-05-04 08:57:14 UTC) #3
pkx166h
http://codereview.appspot.com/6137050/diff/1/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/6137050/diff/1/Documentation/notation/input.itely#newcode1050 Documentation/notation/input.itely:1050: footnote is being attached but can also be attached ...
6 years, 2 months ago (2012-05-04 19:31:25 UTC) #4
dak
Ok, everybody will love me for my late thinking again. But here we go: we ...
6 years, 2 months ago (2012-05-04 19:43:32 UTC) #5
t.daniels_treda.co.uk
<dak@gnu.org> wrote Friday, May 04, 2012 8:43 PM > Ok, everybody will love me for ...
6 years, 2 months ago (2012-05-04 20:21:14 UTC) #6
Carl
On 2012/05/04 20:21:14, t.daniels_treda.co.uk wrote: > <mailto:dak@gnu.org> wrote Friday, May 04, 2012 8:43 PM > ...
6 years, 2 months ago (2012-05-04 21:32:07 UTC) #7
pkx166h
New patch set uploaded for the <> change.
6 years, 2 months ago (2012-05-12 14:01:46 UTC) #8
dak
http://codereview.appspot.com/6137050/diff/11001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/6137050/diff/11001/Documentation/notation/input.itely#newcode1050 Documentation/notation/input.itely:1050: is to be attached but in that case, it ...
6 years, 2 months ago (2012-05-12 14:25:08 UTC) #9
pkx166h
See inline. One more patch will be needed. http://codereview.appspot.com/6137050/diff/11001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/6137050/diff/11001/Documentation/notation/input.itely#newcode1050 Documentation/notation/input.itely:1050: is ...
6 years, 2 months ago (2012-05-12 17:03:10 UTC) #10
Keith
Looks good to me. I honestly tried to use a footnote a couple months ago, ...
6 years, 2 months ago (2012-05-12 18:23:23 UTC) #11
Keith
http://codereview.appspot.com/6137050/diff/11001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/6137050/diff/11001/Documentation/notation/input.itely#newcode1073 Documentation/notation/input.itely:1073: >1 >2 \breathe c2 \footnote #'(0.5 . 0.5) #'BreathingSign ...
6 years, 2 months ago (2012-05-12 18:36:56 UTC) #12
dak
On 2012/05/12 18:36:56, Keith wrote: > http://codereview.appspot.com/6137050/diff/11001/Documentation/notation/input.itely > File Documentation/notation/input.itely (right): > > http://codereview.appspot.com/6137050/diff/11001/Documentation/notation/input.itely#newcode1073 > ...
6 years, 2 months ago (2012-05-12 19:11:44 UTC) #13
dak
On 2012/05/12 19:11:44, dak wrote: > On 2012/05/12 18:36:56, Keith wrote: > > > http://codereview.appspot.com/6137050/diff/11001/Documentation/notation/input.itely ...
6 years, 2 months ago (2012-05-12 19:25:34 UTC) #14
dak
On 2012/05/12 19:25:34, dak wrote: > On 2012/05/12 19:11:44, dak wrote: > > On 2012/05/12 ...
6 years, 2 months ago (2012-05-12 19:31:56 UTC) #15
Keith
On Sat, 12 May 2012 12:11:45 -0700, <dak@gnu.org> wrote: > >> \breathe >> c2 >> ...
6 years, 2 months ago (2012-05-12 21:01:34 UTC) #16
pkx166h
New patch set uploaded http://codereview.appspot.com/6137050/diff/8003/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/6137050/diff/8003/Documentation/notation/input.itely#newcode1044 Documentation/notation/input.itely:1044: Automatic footnotes take three arguments; ...
6 years, 2 months ago (2012-05-13 01:16:56 UTC) #17
Keith
Big change, still very clear. http://codereview.appspot.com/6137050/diff/14003/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/6137050/diff/14003/Documentation/notation/input.itely#newcode1048 Documentation/notation/input.itely:1048: the order in which ...
6 years, 2 months ago (2012-05-13 02:23:08 UTC) #18
Keith
http://codereview.appspot.com/6137050/diff/14003/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/6137050/diff/14003/Documentation/notation/input.itely#newcode1075 Documentation/notation/input.itely:1075: \footnote #'(0.5 , 0.5) #'Accidental \markup { Chromatic } ...
6 years, 2 months ago (2012-05-13 02:32:36 UTC) #19
Jean-Charles
Nitpicks, but I had to read twice and carefully the first paragraph and I'm not ...
6 years, 2 months ago (2012-05-13 09:46:59 UTC) #20
pkx166h
New Patch. Thanks Keith and Jean-Charles http://codereview.appspot.com/6137050/diff/14003/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/6137050/diff/14003/Documentation/notation/input.itely#newcode1037 Documentation/notation/input.itely:1037: customize footnote indicators ...
6 years, 2 months ago (2012-05-13 10:33:23 UTC) #21
Graham Percival
LGTM http://codereview.appspot.com/6137050/diff/22001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/6137050/diff/22001/Documentation/notation/input.itely#newcode1044 Documentation/notation/input.itely:1044: Automatically numbered footnotes take three arguments; the I ...
6 years, 2 months ago (2012-05-14 18:52:01 UTC) #22
pkx166h
6 years, 2 months ago (2012-05-14 19:47:52 UTC) #23
New patch

http://codereview.appspot.com/6137050/diff/22001/Documentation/notation/input...
File Documentation/notation/input.itely (right):

http://codereview.appspot.com/6137050/diff/22001/Documentation/notation/input...
Documentation/notation/input.itely:1044: Automatically numbered footnotes take
three arguments; the
On 2012/05/14 18:52:01, Graham Percival wrote:
> I think this should be a full colon:

Done.

http://codereview.appspot.com/6137050/diff/22001/Documentation/notation/input...
Documentation/notation/input.itely:1136: Customized footnotes take four
arguments; the @var{Layout Object} to be
On 2012/05/14 18:52:01, Graham Percival wrote:
> another :

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b