code review 61330043: cmd/ld, cmd/6l: part 2 of solaris/amd64 linker changes.

cmd/ld, cmd/6l: part 2 of solaris/amd64 linker changes.
Second part of the solaris/amd64 linker changes: relocation and symbol table.

[minux1, 2014-02-09 22:00:43]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[iant, 2014-02-10 01:35:33]

LGTM

https://codereview.appspot.com/61330043/diff/40001/src/cmd/ld/data.c
File src/cmd/ld/data.c (right):

https://codereview.appspot.com/61330043/diff/40001/src/cmd/ld/data.c#newcode157
src/cmd/ld/data.c:157: if(HEADTYPE != Hsolaris && r->sym != S && r->sym->type ==
SDYNIMPORT)
Please add a short comment for the != Hsolaris here.  I think the way you have
written this would work for thechar == '6' && iself, although I don't think you
have to change the code.

https://codereview.appspot.com/61330043/diff/40001/src/cmd/ld/symtab.c
File src/cmd/ld/symtab.c (right):

https://codereview.appspot.com/61330043/diff/40001/src/cmd/ld/symtab.c#newcod...
src/cmd/ld/symtab.c:201: putelfsyment(putelfstr(s->type == SDYNIMPORT ?
s->extname : s->name), 0, 0, (STB_GLOBAL<<4)|STT_NOTYPE, 0, 0);
This code generally avoids the ?: ternary operator.  Please use a local
variable.

[minux1, 2014-02-11 23:43:08]

*** Submitted as https://code.google.com/p/go/source/detail?r=7d72bbcb979d ***

cmd/ld, cmd/6l: part 2 of solaris/amd64 linker changes.
Second part of the solaris/amd64 linker changes: relocation and symbol table.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://codereview.appspot.com/61330043

[dave_cheney.net, 2014-02-12 19:39:36]

On 2014/02/11 23:43:08, minux wrote:
> *** Submitted as https://code.google.com/p/go/source/detail?r=7d72bbcb979d ***
> 
> cmd/ld, cmd/6l: part 2 of solaris/amd64 linker changes.
> Second part of the solaris/amd64 linker changes: relocation and symbol table.
> 
> LGTM=iant
> R=golang-codereviews, iant
> CC=golang-codereviews
> https://codereview.appspot.com/61330043

This change broke dragonfly/amd64

http://build.golang.org/log/c1b69ebabda4e302ae97346b58d9bdf8aa1b3e1d

[minux1, 2014-02-13 00:36:25]

On Feb 12, 2014 2:39 PM, <dave@cheney.net> wrote:
> This change broke dragonfly/amd64
>
> http://build.golang.org/log/c1b69ebabda4e302ae97346b58d9bdf8aa1b3e1d
I will need access to a dfly machine to fix this.
(booting failed every time i tried to run dragonfly inside KVM)