Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(138)

Issue 61300043: code review 61300043: jwt: assertion time is not updated before JWT refresh

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by karalabe
Modified:
10 years, 1 month ago
Reviewers:
adg
CC:
golang-dev, adg
Visibility:
Public.

Description

jwt: assertion time is not updated before JWT refresh The assertion and expiration time in the claim set do not get updated before fetching a new JWT, hence all refreshed tokens will already be expired.

Patch Set 1 #

Patch Set 2 : diff -r 5877582f0cb0 https://code.google.com/p/goauth2 #

Patch Set 3 : diff -r 5877582f0cb0 https://code.google.com/p/goauth2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M oauth/jwt/jwt.go View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3
karalabe
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/goauth2
10 years, 1 month ago (2014-02-09 21:01:01 UTC) #1
adg
LGTM
10 years, 1 month ago (2014-02-11 06:23:58 UTC) #2
adg
10 years, 1 month ago (2014-02-11 06:30:31 UTC) #3
*** Submitted as https://code.google.com/p/goauth2/source/detail?r=30c203fe2959
***

jwt: assertion time is not updated before JWT refresh

The assertion and expiration time in the claim set do not get updated
before fetching a new JWT, hence all refreshed tokens will already be
expired.

LGTM=adg
R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/61300043

Committer: Andrew Gerrand <adg@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b