Added ResolvedWatcher for Units.

Added ResolvedWatcher for Units.

It reads the resolved mode out of the node content if
it's created or changed.

https://code.launchpad.net/~themue/juju/go/+merge/103315

(do not edit description out of merge proposal)

[TheMue, 2012-04-24 16:06:43]

Please take a look.

[niemeyer, 2012-04-25 05:34:26]

Very nice. Just doc suggestions, except for the missing ok check, similar to
what was done in the other branches.

https://codereview.appspot.com/6120045/diff/1/state/unit.go
File state/unit.go (right):

https://codereview.appspot.com/6120045/diff/1/state/unit.go#newcode470
state/unit.go:470: // and checks if it's valid.
// parseResolvedMode returns the resolved mode serialized
// in yaml if it is valid, or an error otherwise.

https://codereview.appspot.com/6120045/diff/1/state/unit.go#newcode486
state/unit.go:486: // resolved mode are used.
// validResolvedMode returns an error if the provided
// mode isn't valid. ResolvedNone is only considered a
// valid mode if acceptNone is true.

https://codereview.appspot.com/6120045/diff/1/state/unit.go#newcode563
state/unit.go:563: // ResolvedWatcher observes changes to a resolved flag node.
// ResolvedWatcher observes changes to a unit's resolved
// mode. See SetResolved for details.

https://codereview.appspot.com/6120045/diff/1/state/unit.go#newcode573
state/unit.go:573: // watcher for the given path.
// newResolvedWatcher returns a new ResolvedWatcher watching path.

https://codereview.appspot.com/6120045/diff/1/state/unit.go#newcode613
state/unit.go:613: case change := <-w.watcher.Changes():
This needs to check for ok in a similar way to what was done in the other
watchers.

[TheMue, 2012-04-25 10:50:47]

Please take a look.

https://codereview.appspot.com/6120045/diff/1/state/unit.go
File state/unit.go (right):

https://codereview.appspot.com/6120045/diff/1/state/unit.go#newcode470
state/unit.go:470: // and checks if it's valid.
On 2012/04/25 05:34:26, niemeyer wrote:
> // parseResolvedMode returns the resolved mode serialized
> // in yaml if it is valid, or an error otherwise.

Done.

https://codereview.appspot.com/6120045/diff/1/state/unit.go#newcode486
state/unit.go:486: // resolved mode are used.
On 2012/04/25 05:34:26, niemeyer wrote:
> // validResolvedMode returns an error if the provided
> // mode isn't valid. ResolvedNone is only considered a
> // valid mode if acceptNone is true.

Done.

https://codereview.appspot.com/6120045/diff/1/state/unit.go#newcode563
state/unit.go:563: // ResolvedWatcher observes changes to a resolved flag node.
On 2012/04/25 05:34:26, niemeyer wrote:
> // ResolvedWatcher observes changes to a unit's resolved
> // mode. See SetResolved for details.

Done.

https://codereview.appspot.com/6120045/diff/1/state/unit.go#newcode573
state/unit.go:573: // watcher for the given path.
On 2012/04/25 05:34:26, niemeyer wrote:
> // newResolvedWatcher returns a new ResolvedWatcher watching path.

Done.

https://codereview.appspot.com/6120045/diff/1/state/unit.go#newcode613
state/unit.go:613: case change := <-w.watcher.Changes():
On 2012/04/25 05:34:26, niemeyer wrote:
> This needs to check for ok in a similar way to what was done in the other
> watchers.

Done.

[niemeyer, 2012-04-25 14:38:24]

LGTM, thanks!

[TheMue, 2012-04-25 14:48:41]

*** Submitted:

Added ResolvedWatcher for Units.

It reads the resolved mode out of the node content if
it's created or changed.

R=niemeyer
CC=
https://codereview.appspot.com/6120045

[TheMue, 2012-06-06 12:46:42]

Please take a look.

[niemeyer, 2012-06-06 12:50:06]

<niemeyer> TheMue: You've just reproposed a branch that has already been
submitted: https://codereview.appspot.com/6120045/
<niemeyer> TheMue: Probably because of the vague branch name ("go")