Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1759)

Issue 6118047: Support smart formatting for relation-ids command

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by jimbaker
Modified:
12 years ago
Reviewers:
hazmat, mp+103387
Visibility:
Public.

Description

Support smart formatting for relation-ids command Adds format_smart method for RelationIdsCli, which outputs whitespace separated (to be precise, per line) relation idents. https://code.launchpad.net/~jimbaker/juju/relation-ids-whitespace-separated/+merge/103387 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Support smart formatting for relation-ids command #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -1 line) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M juju/hooks/commands.py View 1 chunk +4 lines, -0 lines 0 comments Download
M juju/hooks/tests/test_invoker.py View 1 1 chunk +27 lines, -1 line 0 comments Download

Messages

Total messages: 5
jimbaker
Please take a look.
12 years ago (2012-04-24 22:22:36 UTC) #1
hazmat
fix looks straightforwards, its just not clear its as intended https://codereview.appspot.com/6118047/diff/1/juju/hooks/tests/test_invoker.py File juju/hooks/tests/test_invoker.py (right): https://codereview.appspot.com/6118047/diff/1/juju/hooks/tests/test_invoker.py#newcode1105 ...
12 years ago (2012-04-24 23:51:25 UTC) #2
jimbaker
Please take a look.
12 years ago (2012-04-25 00:21:15 UTC) #3
jimbaker
Fixed in latest version of the MP https://codereview.appspot.com/6118047/diff/1/juju/hooks/tests/test_invoker.py File juju/hooks/tests/test_invoker.py (right): https://codereview.appspot.com/6118047/diff/1/juju/hooks/tests/test_invoker.py#newcode1105 juju/hooks/tests/test_invoker.py:1105: """Verify `relation-ids` ...
12 years ago (2012-04-25 00:25:37 UTC) #4
hazmat
12 years ago (2012-04-25 02:58:48 UTC) #5
lgtm, pls also update the spec as thats what most people will read for docs.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b