Issue 6117064: environs: add UploadTools method

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6117064: environs: add UploadTools method

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by rog

Modified:
12 years ago

Reviewers:
mp+103730

Visibility:
Public.

Description

environs: add UploadTools method Just a stub as yet. https://code.launchpad.net/~rogpeppe/juju/go-upload-tools/+merge/103730 Requires: https://code.launchpad.net/~rogpeppe/juju/go-more-commands/+merge/103532 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs: add UploadTools method #

Patch Set 3 : environs: add UploadTools method #

Patch Set 4 : environs: add UploadTools method #

Patch Set 5 : environs: add UploadTools method #

Total comments: 5

Patch Set 6 : environs: add UploadTools method #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -0 lines)			Patch
A	[revision details]	View	1 2 3 4 5	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/dummy/environs.go	View	1 2 3 4 5	2 chunks	+5 lines, -0 lines	0 comments	Download
M	environs/ec2/state.go	View	1 2 3 4 5	2 chunks	+5 lines, -0 lines	0 comments	Download
M	environs/interface.go	View		2 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

TheMue

Only few comments. https://codereview.appspot.com/6117064/diff/7001/environs/dummy/environs.go File environs/dummy/environs.go (right): https://codereview.appspot.com/6117064/diff/7001/environs/dummy/environs.go#newcode258 environs/dummy/environs.go:258: e.state.mu.Lock() Stumbled over "mu" as identifier. ...

12 years ago (2012-04-26 17:07:43 UTC) #3

rog

12 years ago (2012-04-27 08:52:38 UTC) #4

*** Submitted:

environs: add UploadTools method

Just a stub as yet.

R=niemeyer, TheMue
CC=
https://codereview.appspot.com/6117064

https://codereview.appspot.com/6117064/diff/7001/environs/dummy/environs.go
File environs/dummy/environs.go (right):

https://codereview.appspot.com/6117064/diff/7001/environs/dummy/environs.go#n...
environs/dummy/environs.go:258: e.state.mu.Lock()
On 2012/04/26 17:07:43, TheMue wrote:
> Stumbled over "mu" as identifier. Like "mux" or "mutex" more.

it's a standard name. try grepping for '^[ 	]*mu[ 	]+sync.Mutex' in the Go
source tree.

https://codereview.appspot.com/6117064/diff/7001/environs/dummy/environs.go#n...
environs/dummy/environs.go:265: return fmt.Errorf("dummy environ does not
support executable upload")
On 2012/04/26 17:07:43, TheMue wrote:
> To the user we talk about environments. So the error message should be "dummy
> environment does ...".

Done.

Expand All Messages | Collapse All Messages