Issue 6114061: juju-log shouldn't log {} to stdout

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6114061: juju-log shouldn't log {} to stdout

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by bcsaller

Modified:
11 years, 12 months ago

Reviewers:
hazmat, mp+103762

Visibility:
Public.

Description

juju-log shouldn't log {} to stdout The default output format for juju-log was including a marshalled response of an empty dict. This masks that output. https://code.launchpad.net/~bcsaller/juju/log-output/+merge/103762 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : juju-log shouldn't log {} to stdout #

Total comments: 1

Created: 11 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -5 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	juju/hooks/commands.py	View	1	2 chunks	+5 lines, -2 lines	1 comment	Download
M	juju/hooks/tests/test_invoker.py	View	1	2 chunks	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

hazmat

i'd suggest an additional test for config-get against an empty config to ensure this only ...

12 years ago (2012-04-27 13:03:56 UTC) #2

hazmat

11 years, 12 months ago (2012-05-03 16:43:27 UTC) #4

lgtm

https://codereview.appspot.com/6114061/diff/3001/juju/hooks/commands.py
File juju/hooks/commands.py (right):

https://codereview.appspot.com/6114061/diff/3001/juju/hooks/commands.py#newco...
juju/hooks/commands.py:140: self.options.relation_id)
nitpick, odd indentation

Expand All Messages | Collapse All Messages