code review 61070044: cmd/go: fix test.bash

cmd/go: fix test.bash

Fixes issue 7260.

Fix three broken tests in test.bash

The test for issue 4568 was confused by go $ACTION . producing a package root of "", avoiding this mode fixes the test but weakens the test.

The test for issue 4773 was broken on linux because math/Rand would fail to resolve as a package causing the test for duplicates to be skipped.

Finally, the last breakage was a small change in the error message.

Also, add test for foldDup.

[dave_cheney.net, 2014-02-09 03:38:37]

Hello iant@golang.org, rsc@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[iant, 2014-02-09 20:34:42]

LGTM

https://codereview.appspot.com/61070044/diff/60001/src/cmd/go/test.bash
File src/cmd/go/test.bash (right):

https://codereview.appspot.com/61070044/diff/60001/src/cmd/go/test.bash#newco...
src/cmd/go/test.bash:482: mkdir -p $d/src/example/{a,a/a,a/A,b}
No need to list "a", if mkdir -p works creating a/a and a/A will create a.

[dave_cheney.net, 2014-02-09 23:36:24]

On 2014/02/09 20:34:42, iant wrote:
> LGTM
> 
> https://codereview.appspot.com/61070044/diff/60001/src/cmd/go/test.bash
> File src/cmd/go/test.bash (right):
> 
>
https://codereview.appspot.com/61070044/diff/60001/src/cmd/go/test.bash#newco...
> src/cmd/go/test.bash:482: mkdir -p $d/src/example/{a,a/a,a/A,b}
> No need to list "a", if mkdir -p works creating a/a and a/A will create a.

Of course, I was being thick. I've adjusted the path slightly to remove the
repetition of as.

[dave_cheney.net, 2014-02-09 23:42:15]

*** Submitted as https://code.google.com/p/go/source/detail?r=b1f7a2f34d33 ***

cmd/go: fix test.bash

Fixes issue 7260.

Fix three broken tests in test.bash

The test for issue 4568 was confused by go $ACTION . producing a package root of
"", avoiding this mode fixes the test but weakens the test.

The test for issue 4773 was broken on linux because math/Rand would fail to
resolve as a package causing the test for duplicates to be skipped.

Finally, the last breakage was a small change in the error message.

Also, add test for foldDup.

LGTM=iant
R=iant, rsc
CC=golang-codereviews
https://codereview.appspot.com/61070044

[gobot, 2014-02-09 23:46:37]

This CL appears to have broken the freebsd-amd64 builder.

[dave_cheney.net, 2014-02-09 23:51:27]

False.


On Mon, Feb 10, 2014 at 10:46 AM, <gobot@golang.org> wrote:

> This CL appears to have broken the freebsd-amd64 builder.
>
> https://codereview.appspot.com/61070044/
>