hideNotes should hide also TabNoteHead (issue 2480).

hideNotes should hide also TabNoteHead (issue 2480).
Tablature example updated accordingly.

[Graham Percival, 2012-04-22 08:56:52]

LGTM

[Keith, 2012-04-23 04:50:21]

works good for me.

I can see the sense in either splitting into two commits as you mentioned in
email (the \hideNotes commit first) or combining into one (which makes more
sense to me since they are so closely related).

http://codereview.appspot.com/6105049/diff/1/Documentation/ly-examples/tab-ex...
File Documentation/ly-examples/tab-example.ly (left):

http://codereview.appspot.com/6105049/diff/1/Documentation/ly-examples/tab-ex...
Documentation/ly-examples/tab-example.ly:41: < e-3 >\2 ( <d-1> b ) \grace <
ais-2 >16 ( \glissando a8 g ) s4.
I need an
  \override NoteColumn #'ignore-collision = ##t
here or else I get a warning (either before or after this patch).  I mention
this only because I broke the doc build not too long ago by causing a warning
from Lilypond input in the docs. (patchy didn't catch this, at the time.)

[Neil Puttock, 2012-04-23 12:03:41]

On 2012/04/23 04:50:21, Keith wrote:

> I need an
>   \override NoteColumn #'ignore-collision = ##t
> here or else I get a warning (either before or after this patch).  I mention
> this only because I broke the doc build not too long ago by causing a warning
> from Lilypond input in the docs. (patchy didn't catch this, at the time.)

It would make more sense to use \voiceOne for the upper voice.

[dak, 2012-04-23 12:09:15]

On 2012/04/23 12:03:41, Neil Puttock wrote:
> On 2012/04/23 04:50:21, Keith wrote:
> 
> > I need an
> >   \override NoteColumn #'ignore-collision = ##t
> > here or else I get a warning (either before or after this patch).  I mention
> > this only because I broke the doc build not too long ago by causing a
warning
> > from Lilypond input in the docs. (patchy didn't catch this, at the time.)
> 
> It would make more sense to use \voiceOne for the upper voice.

\voiceOne is already used for the upper voice.  The problem is that the voice
settings are totally messed up by the standard grace synchronization problem. 
Remove the graces, and the score typesets fine.

[Neil Puttock, 2012-04-23 12:20:36]

On 2012/04/23 12:09:15, dak wrote:

> \voiceOne is already used for the upper voice.  The problem is that the voice
> settings are totally messed up by the standard grace synchronization problem. 
> Remove the graces, and the score typesets fine.

Ah, I didn't scroll down that far. :) Nevertheless, the voicing should be fixed
even if it means adding explicit \voiceOne commands at appropriate places.  It
looks bad with both voices stem-down.

The glissando overrides are messed up too.  Probably since Mike added code which
avoids accidentals automatically (though this should be generalized for other
side-supports such as fingerings).

[Keith, 2012-04-23 17:28:02]

On 2012/04/23 12:09:15, dak wrote:
> Remove the graces, and the score typesets fine.

Removing the initial acciaccatura seems appropriate here. It is used as an
example of what LilyPond can do; but starting with a grace note is not yet
something LilyPond can do.
Changing the music is no problem because this example does not make musical
sense --it is only a typesetting example.

http://codereview.appspot.com/6105049/diff/1/Documentation/ly-examples/tab-ex...
File Documentation/ly-examples/tab-example.ly (left):

http://codereview.appspot.com/6105049/diff/1/Documentation/ly-examples/tab-ex...
Documentation/ly-examples/tab-example.ly:49: \partial 4. s4.
The manual would recommend a synchronizing grace skip here,
   \partial 4. \grace s16 s4.
and that, instead of the override I suggested earlier, clears the warnings. 
But, now the \voiceOne and \voiceTwo settings are reversed.

[fedelogy, 2012-04-25 21:38:31]

On 2012/04/23 12:20:36, Neil Puttock wrote:
> Nevertheless, the voicing should be fixed
> even if it means adding explicit \voiceOne commands at appropriate places.  It
> looks bad with both voices stem-down.
> 

voiceOne and voiceTwo were already present.
The stem direction was messed up by the grace at the beginning of the piece. I
removed it and now stems look good.

[Graham Percival, 2012-04-27 07:50:24]

LGTM