Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1698)

Issue 6105049: hideNotes should hide also TabNoteHead (issue 2480). (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 2 months ago by fedelogy
Modified:
7 years, 1 month ago
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

hideNotes should hide also TabNoteHead (issue 2480). Tablature example updated accordingly.

Patch Set 1 #

Total comments: 2

Patch Set 2 : hideNotes should hide also TabNoteHead (issue 2480). #

Patch Set 3 : hideNotes should hide also TabNoteHead (issue 2480). Tablature example updated accordingly. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -13 lines) Patch
M Documentation/ly-examples/tab-example.ly View 1 3 chunks +2 lines, -13 lines 0 comments Download
M ly/property-init.ly View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8
Graham Percival
LGTM
7 years, 2 months ago (2012-04-22 08:56:52 UTC) #1
Keith
works good for me. I can see the sense in either splitting into two commits ...
7 years, 2 months ago (2012-04-23 04:50:21 UTC) #2
Neil Puttock
On 2012/04/23 04:50:21, Keith wrote: > I need an > \override NoteColumn #'ignore-collision = ##t ...
7 years, 2 months ago (2012-04-23 12:03:41 UTC) #3
dak
On 2012/04/23 12:03:41, Neil Puttock wrote: > On 2012/04/23 04:50:21, Keith wrote: > > > ...
7 years, 2 months ago (2012-04-23 12:09:15 UTC) #4
Neil Puttock
On 2012/04/23 12:09:15, dak wrote: > \voiceOne is already used for the upper voice. The ...
7 years, 2 months ago (2012-04-23 12:20:36 UTC) #5
Keith
On 2012/04/23 12:09:15, dak wrote: > Remove the graces, and the score typesets fine. Removing ...
7 years, 2 months ago (2012-04-23 17:28:02 UTC) #6
fedelogy
On 2012/04/23 12:20:36, Neil Puttock wrote: > Nevertheless, the voicing should be fixed > even ...
7 years, 2 months ago (2012-04-25 21:38:31 UTC) #7
Graham Percival
7 years, 2 months ago (2012-04-27 07:50:24 UTC) #8
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b