Issue 61045: Support OAuth 1.0a for inbound and outbound OAuth.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 61045: Support OAuth 1.0a for inbound and outbound OAuth.

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 12 months ago by beaton

Modified:
14 years, 9 months ago

Reviewers:
Paul Lindner, shindig.remailer, etnu00

Base URL:
https://svn.apache.org/repos/asf/incubator/shindig/trunk/

Visibility:
Public.

Description

Very, very rough first start. Tests don't even compile, much less pass. I think I'm going to tweak the outbound stuff to reduce the coupling between OAuthRequest and OAuthCallbackServlet. The inbound stuff I think is fine as is, but I have fewer production dependencies on that. Feedback on whether this is acceptable would be welcome. There is some magic happening here: gadgets that use the oauthpopup library don't need to change, at all, in order to support OAuth 1.0a. This requires some ugly logic in gadgets.io.makeRequest. Suggestions for more elegant solutions would be welcome.

Patch Set 1 #

Created: 14 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+419 lines, -81 lines)			Patch
M	features/src/main/javascript/features/core.io/io.js	View	2 chunks	+9 lines, -1 line	0 comments	Download
M	features/src/main/javascript/features/oauthpopup/oauthpopup.js	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	features/src/test/javascript/features/mocks/env.js	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	java/common/conf/shindig.properties	View	1 chunk	+8 lines, -2 lines	0 comments	Download
M	java/common/src/main/java/org/apache/shindig/auth/OAuthConstants.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	java/common/src/main/java/org/apache/shindig/common/crypto/Crypto.java	View	2 chunks	+14 lines, -0 lines	0 comments	Download
M	java/common/src/main/java/org/apache/shindig/common/uri/UriBuilder.java	View	2 chunks	+9 lines, -1 line	0 comments	Download
M	java/common/src/test/java/org/apache/shindig/common/crypto/CryptoTest.java	View	3 chunks	+11 lines, -0 lines	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/BasicOAuthStore.java	View	6 chunks	+9 lines, -3 lines	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/BasicOAuthStoreConsumerKeyAndSecret.java	View	2 chunks	+10 lines, -1 line	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthArguments.java	View	6 chunks	+24 lines, -2 lines	0 comments	Download
A	java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthCallbackState.java	View	1 chunk	+71 lines, -0 lines	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthFetcherConfig.java	View	2 chunks	+10 lines, -1 line	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthModule.java	View	3 chunks	+6 lines, -3 lines	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java	View	5 chunks	+29 lines, -3 lines	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthStore.java	View	2 chunks	+9 lines, -1 line	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/OAuthCallbackServlet.java	View	2 chunks	+64 lines, -18 lines	0 comments	Download
M	java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth/BasicOAuthStoreTest.java	View	6 chunks	+13 lines, -3 lines	0 comments	Download
M	java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth/GadgetTokenStoreTest.java	View	9 chunks	+19 lines, -17 lines	0 comments	Download
M	java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth/OAuthFetcherConfigTest.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth/OAuthRequestTest.java	View	13 chunks	+15 lines, -15 lines	0 comments	Download
M	java/social-api/src/main/java/org/apache/shindig/social/core/oauth/OAuthAuthenticationHandler.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	java/social-api/src/main/java/org/apache/shindig/social/opensocial/oauth/OAuthDataStore.java	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	java/social-api/src/main/java/org/apache/shindig/social/opensocial/oauth/OAuthEntry.java	View	4 chunks	+7 lines, -1 line	0 comments	Download
M	java/social-api/src/main/java/org/apache/shindig/social/sample/oauth/SampleOAuthDataStore.java	View	5 chunks	+20 lines, -2 lines	0 comments	Download
M	java/social-api/src/main/java/org/apache/shindig/social/sample/oauth/SampleOAuthServlet.java	View	7 chunks	+45 lines, -4 lines	0 comments	Download