code review 60900043: net: remove superfluous type conversion

net: remove superfluous type conversion

[brainman, 2014-02-07 05:52:35]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[minux1, 2014-02-07 05:55:27]

LGTM.  I wonder why it was written that way?

[dvyukov, 2014-02-07 05:55:29]

LGTM

On Fri, Feb 7, 2014 at 9:52 AM,  <alex.brainman@gmail.com> wrote:
> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> net: remove superfluous type conversion
>
> Please review this at https://codereview.appspot.com/60900043/
>
> Affected files (+1, -1 lines):
>   M src/pkg/net/fd_windows.go
>
>
> Index: src/pkg/net/fd_windows.go
> ===================================================================
> --- a/src/pkg/net/fd_windows.go
> +++ b/src/pkg/net/fd_windows.go
> @@ -119,7 +119,7 @@
>         o.buf.Len = uint32(len(buf))
>         o.buf.Buf = nil
>         if len(buf) != 0 {
> -               o.buf.Buf = (*byte)(unsafe.Pointer(&buf[0]))
> +               o.buf.Buf = &buf[0]
>         }
>  }
>
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

[brainman, 2014-02-07 05:57:47]

On 2014/02/07 05:55:27, minux wrote:
> LGTM.  I wonder why it was written that way?

I don't know. I won't go hunting now that I had couple beers.

Alex

[brainman, 2014-02-07 05:58:55]

*** Submitted as https://code.google.com/p/go/source/detail?r=e2f19c96b7e2 ***

net: remove superfluous type conversion

LGTM=minux.ma, dvyukov
R=golang-codereviews, minux.ma, dvyukov
CC=golang-codereviews
https://codereview.appspot.com/60900043