Issue 60880044: Doc: misplaced comment produces wrong HTML output.
|
Created:
10 years, 2 months ago by pacovila Modified:
10 years, 2 months ago Reviewers:
Graham Percival, mail CC:
lilypond-devel_gnu.org Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/ Visibility:
Public. |
DescriptionDoc: misplaced comment produces wrong HTML output.
Patch Set 1 #
MessagesTotal messages: 7
Was this fix produced automatically by running import-lsr.py (or whatever the script is called), or was it done manually? Remember that this file begins with % DO NOT EDIT this file manually If there's a bug in the import script, then this bug will just re-appear the next time somebody imports LSR.
Sign in to reply to this message.
----- Original Message ----- From: <graham@percival-music.ca> To: <paconet.org@gmail.com> Cc: <reply@codereview-hr.appspotmail.com>; <lilypond-devel@gnu.org> Sent: Sunday, February 09, 2014 10:08 AM Subject: Doc: misplaced comment produces wrong HTML output. (issue 60880044) > Was this fix produced automatically by running import-lsr.py (or > whatever the script is called), or was it done manually? Remember that > this file begins with > % DO NOT EDIT this file manually > > If there's a bug in the import script, then this bug will just re-appear > the next time somebody imports LSR. > > https://codereview.appspot.com/60880044/ It looks like it's actually a spurious comment in Documentation/snippets/new/creating-a-delayed-turn.ly This needs correcting then scripts/auxiliar/makelsr.py needs to be run. -- Phil Holmes
Sign in to reply to this message.
2014-02-09 11:23 GMT+01:00 Phil Holmes <mail@philholmes.net>: > ----- Original Message ----- From: <graham@percival-music.ca> > To: <paconet.org@gmail.com> > Cc: <reply@codereview-hr.appspotmail.com>; <lilypond-devel@gnu.org> > Sent: Sunday, February 09, 2014 10:08 AM > Subject: Doc: misplaced comment produces wrong HTML output. (issue 60880044) > > >> Was this fix produced automatically by running import-lsr.py (or >> whatever the script is called), or was it done manually? Remember that >> this file begins with >> % DO NOT EDIT this file manually >> >> If there's a bug in the import script, then this bug will just re-appear >> the next time somebody imports LSR. >> >> https://codereview.appspot.com/60880044/ > > > > It looks like it's actually a spurious comment in > Documentation/snippets/new/creating-a-delayed-turn.ly What's strange is that creating-a-delayed-turn.ly in Documentation/snippets/new does NOT have the spurious comment. Only creating-a-delayed-turn.ly in Documentation/snippets/ does. > This needs correcting then scripts/auxiliar/makelsr.py needs to be run. > -- > Phil Holmes -- Francisco Vila. Badajoz (Spain) www.paconet.org , www.csmbadajoz.com
Sign in to reply to this message.
----- Original Message ----- From: "Francisco Vila" <paconet.org@gmail.com> To: "Phil Holmes" <mail@philholmes.net> Cc: "Graham Percival" <graham@percival-music.ca>; "LilyPond-Devel list" <lilypond-devel@gnu.org>; <reply@codereview-hr.appspotmail.com> Sent: Sunday, February 09, 2014 10:45 AM Subject: Re: misplaced comment produces wrong HTML output. (issue 60880044) > 2014-02-09 11:23 GMT+01:00 Phil Holmes <mail@philholmes.net>: >> ----- Original Message ----- From: <graham@percival-music.ca> >> To: <paconet.org@gmail.com> >> Cc: <reply@codereview-hr.appspotmail.com>; <lilypond-devel@gnu.org> >> Sent: Sunday, February 09, 2014 10:08 AM >> Subject: Doc: misplaced comment produces wrong HTML output. (issue >> 60880044) >> >> >>> Was this fix produced automatically by running import-lsr.py (or >>> whatever the script is called), or was it done manually? Remember that >>> this file begins with >>> % DO NOT EDIT this file manually >>> >>> If there's a bug in the import script, then this bug will just re-appear >>> the next time somebody imports LSR. >>> >>> https://codereview.appspot.com/60880044/ >> >> >> >> It looks like it's actually a spurious comment in >> Documentation/snippets/new/creating-a-delayed-turn.ly > > What's strange is that creating-a-delayed-turn.ly in > > Documentation/snippets/new > > does NOT have the spurious comment. > > Only creating-a-delayed-turn.ly in > > Documentation/snippets/ > > does. It does have it, but in a different place, and I presume this confuses makelsr: " doctitle = "Creating a delayed turn" } % begin verbatim \relative c'' { c2*2/3 ( s2*1/3\turn d4) r << -- Phil Holmes
Sign in to reply to this message.
2014-02-09 12:23 GMT+01:00 Phil Holmes <mail@philholmes.net>: > ----- Original Message ----- From: "Francisco Vila" <paconet.org@gmail.com> > To: "Phil Holmes" <mail@philholmes.net> > Cc: "Graham Percival" <graham@percival-music.ca>; "LilyPond-Devel list" > <lilypond-devel@gnu.org>; <reply@codereview-hr.appspotmail.com> > Sent: Sunday, February 09, 2014 10:45 AM > Subject: Re: misplaced comment produces wrong HTML output. (issue 60880044) > > > >> 2014-02-09 11:23 GMT+01:00 Phil Holmes <mail@philholmes.net>: >>> >>> ----- Original Message ----- From: <graham@percival-music.ca> >>> To: <paconet.org@gmail.com> >>> Cc: <reply@codereview-hr.appspotmail.com>; <lilypond-devel@gnu.org> >>> Sent: Sunday, February 09, 2014 10:08 AM >>> Subject: Doc: misplaced comment produces wrong HTML output. (issue >>> 60880044) >>> >>> >>>> Was this fix produced automatically by running import-lsr.py (or >>>> whatever the script is called), or was it done manually? Remember that >>>> this file begins with >>>> % DO NOT EDIT this file manually >>>> >>>> If there's a bug in the import script, then this bug will just re-appear >>>> the next time somebody imports LSR. >>>> >>>> https://codereview.appspot.com/60880044/ >>> >>> >>> >>> >>> It looks like it's actually a spurious comment in >>> Documentation/snippets/new/creating-a-delayed-turn.ly >> >> >> What's strange is that creating-a-delayed-turn.ly in >> >> Documentation/snippets/new >> >> does NOT have the spurious comment. >> >> Only creating-a-delayed-turn.ly in >> >> Documentation/snippets/ >> >> does. > > > It does have it, but in a different place, and I presume this confuses > makelsr: Terminology issue here. The required comment is not the spurious comment. -- Francisco Vila. Badajoz (Spain) www.paconet.org , www.csmbadajoz.com
Sign in to reply to this message.
----- Original Message ----- From: "Francisco Vila" <paconet.org@gmail.com> To: "Phil Holmes" <mail@philholmes.net> Cc: "Graham Percival" <graham@percival-music.ca>; "LilyPond-Devel list" <lilypond-devel@gnu.org>; <reply@codereview-hr.appspotmail.com> Sent: Sunday, February 09, 2014 11:59 AM Subject: Re: misplaced comment produces wrong HTML output. (issue 60880044) > 2014-02-09 12:23 GMT+01:00 Phil Holmes <mail@philholmes.net>: >> ----- Original Message ----- From: "Francisco Vila" >> <paconet.org@gmail.com> >> To: "Phil Holmes" <mail@philholmes.net> >> Cc: "Graham Percival" <graham@percival-music.ca>; "LilyPond-Devel list" >> <lilypond-devel@gnu.org>; <reply@codereview-hr.appspotmail.com> >> Sent: Sunday, February 09, 2014 10:45 AM >> Subject: Re: misplaced comment produces wrong HTML output. (issue >> 60880044) >> >> >> >>> 2014-02-09 11:23 GMT+01:00 Phil Holmes <mail@philholmes.net>: >>>> >>>> ----- Original Message ----- From: <graham@percival-music.ca> >>>> To: <paconet.org@gmail.com> >>>> Cc: <reply@codereview-hr.appspotmail.com>; <lilypond-devel@gnu.org> >>>> Sent: Sunday, February 09, 2014 10:08 AM >>>> Subject: Doc: misplaced comment produces wrong HTML output. (issue >>>> 60880044) >>>> >>>> >>>>> Was this fix produced automatically by running import-lsr.py (or >>>>> whatever the script is called), or was it done manually? Remember >>>>> that >>>>> this file begins with >>>>> % DO NOT EDIT this file manually >>>>> >>>>> If there's a bug in the import script, then this bug will just >>>>> re-appear >>>>> the next time somebody imports LSR. >>>>> >>>>> https://codereview.appspot.com/60880044/ >>>> >>>> >>>> >>>> >>>> It looks like it's actually a spurious comment in >>>> Documentation/snippets/new/creating-a-delayed-turn.ly >>> >>> >>> What's strange is that creating-a-delayed-turn.ly in >>> >>> Documentation/snippets/new >>> >>> does NOT have the spurious comment. >>> >>> Only creating-a-delayed-turn.ly in >>> >>> Documentation/snippets/ >>> >>> does. >> >> >> It does have it, but in a different place, and I presume this confuses >> makelsr: > > Terminology issue here. The required comment is not the spurious comment. OK - let's run through this again. Documentation/snippets/creating-a-delayed-turn.ly is automatically created by makelsr from Documentation/snippets/new/creating-a-delayed-turn.ly. Therefore editing Documentation/snippets/creating-a-delayed-turn.ly will have no long-term effect: the edit will be over-written next time makelsr is run. To correct the error we have to locate the error in Documentation/snippets/new/creating-a-delayed-turn.ly. There is a spurious comment there, albeit in the wrong place. I was suggesting this spurious comment may be confusing makelsr, and whether it is or not, it should definitely be removed and makelsr run again, to check the output. -- Phil Holmes
Sign in to reply to this message.
2014-02-09 13:14 GMT+01:00 Phil Holmes <mail@philholmes.net>: > Documentation/snippets/creating-a-delayed-turn.ly is automatically created > by makelsr from Documentation/snippets/new/creating-a-delayed-turn.ly. > Therefore editing Documentation/snippets/creating-a-delayed-turn.ly will > have no long-term effect: the edit will be over-written next time makelsr is > run. > To correct the error we have to locate the error in > Documentation/snippets/new/creating-a-delayed-turn.ly. There is a spurious > comment there, Correct. In fact, three snippets have this in /new: adding-a-figured-bass-above-or-below-the-notes.ly:} % begin verbatim creating-a-delayed-turn.ly:} % begin verbatim horizontally-aligning-custom-dynamics-e.g.-sempre-pp,-piu-f,-subito-p.ly:} % begin verbatim > albeit in the wrong place The comments should not be there in any place as that clearly confuses makelsr. There is no right place (it seems; to my understanding) for them in snippets/new. All three occurrences in /snippets show extra"%begin verbatim" comments. -- Francisco Vila. Badajoz (Spain) www.paconet.org , www.csmbadajoz.com
Sign in to reply to this message.
|
||||||||||||||||||||||||||||||||||||||||||||||
