Issue 6080047: Add rules to language specification wiki.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6080047: Add rules to language specification wiki. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by bungeman of chrome

Modified:
12 years ago

Reviewers:
Mark Mentovai

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/

Visibility:
Public.

More Reviews

Description

Add rules to language specification wiki.

Patch Set 2 : Fix extra changes. #

Total comments: 2

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -3 lines)			Patch
	M	wiki/GypLanguageSpecification.wiki	View	1	4 chunks	+27 lines, -3 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bungeman of chrome

Rules appear to have no documentation anywhere. They appear to have been added to gyp ...

12 years ago (2012-04-20 17:53:15 UTC) #1

Mark Mentovai

LGTM http://codereview.appspot.com/6080047/diff/3/wiki/GypLanguageSpecification.wiki File wiki/GypLanguageSpecification.wiki (right): http://codereview.appspot.com/6080047/diff/3/wiki/GypLanguageSpecification.wiki#newcode333 wiki/GypLanguageSpecification.wiki:333: There’s one blank line too many here.

12 years ago (2012-04-20 19:57:17 UTC) #2

bungeman of chrome

12 years ago (2012-04-20 20:22:28 UTC) #3

Committed revision r1333.

http://codereview.appspot.com/6080047/diff/3/wiki/GypLanguageSpecification.wiki
File wiki/GypLanguageSpecification.wiki (right):

http://codereview.appspot.com/6080047/diff/3/wiki/GypLanguageSpecification.wi...
wiki/GypLanguageSpecification.wiki:333: 
On 2012/04/20 19:57:17, Mark Mentovai wrote:
> There’s one blank line too many here.

Done.

Expand All Messages | Collapse All Messages