Issue 6072046: store: fix stats=0 handling for /charm/

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6072046: store: fix stats=0 handling for /charm/

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by niemeyer

Modified:
12 years ago

Reviewers:
mp+102730

Visibility:
Public.

Description

store: fix stats=0 handling for /charm/ https://code.launchpad.net/~niemeyer/juju/go-store-nostats-fix/+merge/102730 (do not edit description out of merge proposal)

Patch Set 2 : store: fix stats=0 handling for /charm/ #

Patch Set 3 : store: fix stats=0 handling for /charm/ #

Patch Set 4 : store: fix stats=0 handling for /charm/ #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -3 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	store/server.go	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	store/server_test.go	View	1 2	1 chunk	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

rog

LGTM modulo the comment below. https://codereview.appspot.com/6072046/diff/1/store/server_test.go File store/server_test.go (right): https://codereview.appspot.com/6072046/diff/1/store/server_test.go#newcode113 store/server_test.go:113: req, err = http.NewRequest("GET", ...

12 years ago (2012-04-19 17:42:25 UTC) #4

niemeyer

12 years ago (2012-04-19 17:47:34 UTC) #6

*** Submitted:

store: fix stats=0 handling for /charm/

R=rog
CC=
https://codereview.appspot.com/6072046

Expand All Messages | Collapse All Messages