Issue 60640046: PS search store shows icon of the type of store currently into

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 60640046: PS search store shows icon of the type of store currently into

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by prannoysircar0325

Modified:
10 years, 2 months ago

Reviewers:
mail2coolgarg

Base URL:
https://immpandroid.unfuddle.com/svn/immpandroid_android/

Visibility:
Public.

More Reviews

Description

PS search store shows icon of the type of store currently into

Patch Set 1 #

Total comments: 1

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+150 lines, -129 lines)			Patch
M	ActionsContentViewLib/src/shared/ui/actionscontentview/ActionsContentView.java	View	1 chunk	+3 lines, -1 line	1 comment	Download
A	shoppoke/res/drawable/all_stores.png	View	Binary file		0 comments	Download
	shoppoke/res/drawable/all_stores.png	View	0 chunks	+1 line, -0 lines	0 comments	Download
A	shoppoke/res/drawable/apparels.png	View	Binary file		0 comments	Download
	shoppoke/res/drawable/apparels.png	View	0 chunks	+1 line, -0 lines	0 comments	Download
A	shoppoke/res/drawable/books.png	View	Binary file		0 comments	Download
	shoppoke/res/drawable/books.png	View	0 chunks	+1 line, -0 lines	0 comments	Download
A	shoppoke/res/drawable/cosmetics.png	View	Binary file		0 comments	Download
	shoppoke/res/drawable/cosmetics.png	View	0 chunks	+1 line, -0 lines	0 comments	Download
A	shoppoke/res/drawable/electronics.png	View	Binary file		0 comments	Download
	shoppoke/res/drawable/electronics.png	View	0 chunks	+1 line, -0 lines	0 comments	Download
A	shoppoke/res/drawable/furniture.png	View	Binary file		0 comments	Download
	shoppoke/res/drawable/furniture.png	View	0 chunks	+1 line, -0 lines	0 comments	Download
A	shoppoke/res/drawable/grocery.png	View	Binary file		0 comments	Download
	shoppoke/res/drawable/grocery.png	View	0 chunks	+1 line, -0 lines	0 comments	Download
A	shoppoke/res/drawable/home_decor.png	View	Binary file		0 comments	Download
	shoppoke/res/drawable/home_decor.png	View	0 chunks	+1 line, -0 lines	0 comments	Download
A	shoppoke/res/drawable/kids.png	View	Binary file		0 comments	Download
	shoppoke/res/drawable/kids.png	View	0 chunks	+1 line, -0 lines	0 comments	Download
A	shoppoke/res/drawable/my_stores.png	View	Binary file		0 comments	Download
	shoppoke/res/drawable/my_stores.png	View	0 chunks	+1 line, -0 lines	0 comments	Download
A	shoppoke/res/drawable/travel.png	View	Binary file		0 comments	Download
	shoppoke/res/drawable/travel.png	View	0 chunks	+1 line, -0 lines	0 comments	Download
M	shoppoke/res/layout/header_layout.xml	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	shoppoke/res/layout/store_list.xml	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	shoppoke/res/values/strings.xml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	shoppoke/src/app/shoppoke/BaseSpDefaultFragment.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	shoppoke/src/app/shoppoke/storelist/BaseStoreListFragment.java	View	4 chunks	+44 lines, -21 lines	0 comments	Download
A	spcore/res/drawable/broadcast.png	View	Binary file		0 comments	Download
	spcore/res/drawable/broadcast.png	View	0 chunks	+1 line, -0 lines	0 comments	Download
A	spcore/res/drawable/chat_storegrey.9.png	View	Binary file		0 comments	Download
	spcore/res/drawable/chat_storegrey.9.png	View	0 chunks	+1 line, -0 lines	0 comments	Download
M	spcore/res/layout/chat_list_cell.xml	View	5 chunks	+17 lines, -50 lines	0 comments	Download
M	spcore/res/values/colors.xml	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	spcore/src/app/spcore/activities/login/LoginActivity.java	View	7 chunks	+44 lines, -34 lines	0 comments	Download
M	spcore/src/app/spcore/activities/message/ChatListAdapter.java	View	3 chunks	+18 lines, -18 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

mail2coolgarg

10 years, 2 months ago (2014-02-07 10:33:39 UTC) #1

looks good.

https://codereview.appspot.com/60640046/diff/1/ActionsContentViewLib/src/shar...
File
ActionsContentViewLib/src/shared/ui/actionscontentview/ActionsContentView.java
(right):

https://codereview.appspot.com/60640046/diff/1/ActionsContentViewLib/src/shar...
ActionsContentViewLib/src/shared/ui/actionscontentview/ActionsContentView.java:1258:
//			if (x >= 0) {
remove this comment also.

Expand All Messages | Collapse All Messages