Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(64)

Issue 60550047: code review 60550047: ogle/probe: handle read requests from network (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 9 months ago by r
Modified:
7 years, 7 months ago
Reviewers:
nigeltao
CC:
nigeltao
Visibility:
Public.

Description

ogle/probe: handle read requests from network Basic plumbing to accept a connection and handle requests to read data. Test it by calling one's own process, which is slightly slippery because of potential race conditions. Tests of writing will have to be cleverer.

Patch Set 1 #

Total comments: 46

Patch Set 2 : diff -r e53db6031eee https://code.google.com/p/ogle #

Total comments: 9

Patch Set 3 : diff -r e53db6031eee https://code.google.com/p/ogle #

Unified diffs Side-by-side diffs Delta from patch set Stats (+632 lines, -2 lines) Patch
probe/addr_test.go View 1 chunk +1 line, -1 line 0 comments Download
probe/net.go View 1 2 1 chunk +283 lines, -0 lines 0 comments Download
probe/net_test.go View 1 2 1 chunk +222 lines, -0 lines 0 comments Download
probe/probe.go View 2 chunks +32 lines, -1 line 0 comments Download
probe/size_amd64.go View 1 1 chunk +12 lines, -0 lines 0 comments Download
probe/varint.go View 1 1 chunk +82 lines, -0 lines 0 comments Download

Messages

Total messages: 7
r
Hello nigeltao, I'd like you to review this change to https://code.google.com/p/ogle
7 years, 9 months ago (2014-02-08 05:21:14 UTC) #1
nigeltao
https://codereview.appspot.com/60550047/diff/1/probe/net.go File probe/net.go (right): https://codereview.appspot.com/60550047/diff/1/probe/net.go#newcode109 probe/net.go:109: n, err := network.Read(buf[:1]) Strictly speaking, an io.Reader is ...
7 years, 9 months ago (2014-02-10 04:05:56 UTC) #2
r
Hello nigeltao@golang.org, Please take another look.
7 years, 9 months ago (2014-02-10 22:51:08 UTC) #3
nigeltao
LGTM. https://codereview.appspot.com/60550047/diff/20001/probe/net.go File probe/net.go (right): https://codereview.appspot.com/60550047/diff/20001/probe/net.go#newcode42 probe/net.go:42: server(conn) s/server/serve/ ? https://codereview.appspot.com/60550047/diff/20001/probe/net.go#newcode164 probe/net.go:164: return eof Is ...
7 years, 9 months ago (2014-02-11 01:00:13 UTC) #4
r
sorry - didn't publish my previous comments. https://codereview.appspot.com/60550047/diff/1/probe/net.go File probe/net.go (right): https://codereview.appspot.com/60550047/diff/1/probe/net.go#newcode109 probe/net.go:109: n, err ...
7 years, 9 months ago (2014-02-11 01:38:54 UTC) #5
r
https://codereview.appspot.com/60550047/diff/20001/probe/net.go File probe/net.go (right): https://codereview.appspot.com/60550047/diff/20001/probe/net.go#newcode42 probe/net.go:42: server(conn) On 2014/02/11 01:00:14, nigeltao wrote: > s/server/serve/ ? ...
7 years, 9 months ago (2014-02-11 01:42:52 UTC) #6
r
7 years, 9 months ago (2014-02-11 01:44:12 UTC) #7
*** Submitted as https://code.google.com/p/ogle/source/detail?r=239d84d9b130 ***

ogle/probe: handle read requests from network
Basic plumbing to accept a connection and handle requests to read data.
Test it by calling one's own process, which is slightly slippery because of
potential race conditions. Tests of writing will have to be cleverer.

LGTM=nigeltao
R=nigeltao
https://codereview.appspot.com/60550047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b