Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3579)

Issue 60530047: Add "Editing" page/node

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by uliska
Modified:
10 years, 2 months ago
Reviewers:
phileholmes
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Add "Editing" page/node Web:Text input: Remove LilyKDE image in closing As there is a dedicated page about editing now I think this image here isn't needed anymore. There are already so many nice images on that page. And it's very outdated BTW (a discontinued program). Web: Rewrite Closing of "Text input" Discussion indicated that "Text input" - while very good in itself - isn't sufficient to let all readers get the idea of "editing and compiling". Therefore I added a new page discussing that concept. This commit rewrites the closing of "Text input" to make that clear and @ref to the new page. Web:Introduction: Add link to new Editing node Web:Editing: Add new flow-chart Attention: This image isn't present in lilypond-extra yet. So outside of my dev computer this won't compile correctly. Web: Add node "Editing" As discussed on lilypond-devel I wrote a page discussing the concept of editing and compiling itself. While this factually is self-evident it seems that we need this extra effort in getting potential users on the right track.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add pictures, fix whitespace errors #

Patch Set 3 : Fix color coding of menu #

Total comments: 11
Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -14 lines) Patch
M Documentation/lilypond-texi2html.init View 1 2 1 chunk +1 line, -1 line 0 comments Download
A Documentation/pictures/lilypond-flow.png View 1 Binary file 0 comments Download
A Documentation/pictures/lilypond-flow-de.png View 1 Binary file 0 comments Download
A Documentation/pictures/lilypond-flow-small.png View 1 Binary file 0 comments Download
A Documentation/pictures/lilypond-flow-small-de.png View 1 Binary file 0 comments Download
M Documentation/web/introduction.itexi View 1 4 chunks +98 lines, -13 lines 11 comments Download

Messages

Total messages: 7
uliska
This has been waiting for some time, but is in line with stuff I did ...
10 years, 2 months ago (2014-02-07 12:28:01 UTC) #1
PhilEHolmes
An initial comment: https://codereview.appspot.com/60530047/diff/1/Documentation/web/introduction.itexi File Documentation/web/introduction.itexi (left): https://codereview.appspot.com/60530047/diff/1/Documentation/web/introduction.itexi#oldcode78 Documentation/web/introduction.itexi:78: If I build the web page, ...
10 years, 2 months ago (2014-02-07 14:29:15 UTC) #2
uliska
On 2014/02/07 14:29:15, PhilEHolmes wrote: > An initial comment: > > https://codereview.appspot.com/60530047/diff/1/Documentation/web/introduction.itexi > File Documentation/web/introduction.itexi ...
10 years, 2 months ago (2014-02-07 14:45:28 UTC) #3
uliska
Add pictures, fix whitespace errors
10 years, 2 months ago (2014-02-07 15:33:19 UTC) #4
uliska
On 2014/02/07 15:33:19, uliska wrote: > Add pictures, fix whitespace errors As said earlier, I ...
10 years, 2 months ago (2014-02-07 15:35:27 UTC) #5
uliska
Fix color coding of menu
10 years, 2 months ago (2014-02-07 15:52:51 UTC) #6
PhilEHolmes
10 years, 2 months ago (2014-02-08 14:42:23 UTC) #7
Some proposed changes that help to make it easier to read, I hope.

https://codereview.appspot.com/60530047/diff/40001/Documentation/web/introduc...
File Documentation/web/introduction.itexi (right):

https://codereview.appspot.com/60530047/diff/40001/Documentation/web/introduc...
Documentation/web/introduction.itexi:1190: and how you actually @emph{work} with
these text files you may
Think it's simpler and better to say:

"But if you don't have a clear idea yet how you actually @emph{work} with these
text files"

https://codereview.appspot.com/60530047/diff/40001/Documentation/web/introduc...
Documentation/web/introduction.itexi:1202: LilyPond isn't one monolithic program
as you may be used
one -> a single

https://codereview.appspot.com/60530047/diff/40001/Documentation/web/introduc...
Documentation/web/introduction.itexi:1203: from graphical notation tools. 
Instead it is a system with
graphical music notation tools.

https://codereview.appspot.com/60530047/diff/40001/Documentation/web/introduc...
Documentation/web/introduction.itexi:1204: several independent parts.  This may
seem irritating at first,
"This may seem irritating at first," -> "This may not be what you're used to,"

https://codereview.appspot.com/60530047/diff/40001/Documentation/web/introduc...
Documentation/web/introduction.itexi:1213: of other options, including MIDI.
"there is a variety of other options" is grammatically correct, but sounds odd
to a native.  "there are a variety of other options" sounds better. 
Alternatively "a variety of other options are available, including MIDI" avoids
the issue.

https://codereview.appspot.com/60530047/diff/40001/Documentation/web/introduc...
Documentation/web/introduction.itexi:1219: support you in working with LilyPond
files.
This would read better as:

It can be unnecessarily difficult editing LilyPond input with a plain text
editor, but fortunately there are a number of tools that actively support
working with LilyPond files.

https://codereview.appspot.com/60530047/diff/40001/Documentation/web/introduc...
Documentation/web/introduction.itexi:1236: automatic command completion that
helps you remembering
remembering -> remember

https://codereview.appspot.com/60530047/diff/40001/Documentation/web/introduc...
Documentation/web/introduction.itexi:1237: the available commands and reduces
misspelling errors at the
misspelling -> spelling

https://codereview.appspot.com/60530047/diff/40001/Documentation/web/introduc...
Documentation/web/introduction.itexi:1240: While these are quite basic tools
some programs offer you a
"While these are quite basic tools some programs offer" -> "Some other programs
offer"

https://codereview.appspot.com/60530047/diff/40001/Documentation/web/introduc...
Documentation/web/introduction.itexi:1241: complete editing environment for
working with LilyPond score.
score -> scores

https://codereview.appspot.com/60530047/diff/40001/Documentation/web/introduc...
Documentation/web/introduction.itexi:1242: They may include templates and entry
palettes, may support
"may support" -> "support"
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b