Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6)

Issue 6051: xlC suffers the same can't-decide-which-template-to-use as Symbian

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 4 months ago by Travis
Modified:
1 week, 6 days ago
Reviewers:
Base URL:
http://protobuf.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fortunately, it looks like this problem has already been tackled with Nokia's Symbian compiler. (Yay! It's a bit of a tricky fix.) I'm attaching my draft of a patch (based on 2.0.1 release since I don't see any Subversion repos of trunk) that fixed it up to compile on AIX for me by playing with the defines in gtest and tweaking the docs. xlC's errors look like this: "./gtest/gtest.h", line 631.10: 1540-0219 (S) The call to "FormatForFailureMessage" has no best match. "./gtest/gtest.h", line 631.34: 1540-1228 (I) Argument number 1 is an lvalue of type "const char * const". "./gtest/internal/gtest-internal.h", line 250.15: 1540-1202 (I) No candidate is better than "testing::internal::FormatForFailureMessage<const char>(const char *)". "./gtest/gtest.h", line 631.34: 1540-1231 (I) The conversion from argument number 1 to "const char *" uses "an lvalue-to-rvalue transformation". "./gtest/internal/gtest-internal.h", line 243.15: 1540-1202 (I) No candidate is better than "testing::internal::FormatForFailureMessage<const char *>(const char * const &)". "./gtest/gtest.h", line 631.34: 1540-1231 (I) The conversion from argument number 1 to "const char * const &" uses "the identity conversion". "./gtest/gtest.h", line 629.8: 1540-0700 (I) The previous message was produced while processing "testing::internal::FormatForComparisonFailureMessage<const char *,const char *>(const char * const &, const char * const &)". "./gtest/gtest.h", line 752.1: 1540-0700 (I) The previous message was produced while processing "testing::internal::CmpHelperNE<const char *,const char *>(const char *, const char *, const char * const &, const char * const &)". "google/protobuf/stubs/common_unittest.cc", line 317.3: 1540-0700 (I) The previous message was produced while processing "google::protobuf::<unnamed>::ClosureTest_TestPermanentClosureMethod2_Test: :TestBody()".

Patch Set 1 #

Patch Set 2 : Same changes, but might fix problem where side-by-side diffs didn't work #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -16 lines) Patch
src/gtest/gtest.h View 1 1 chunk +1 line, -0 lines 0 comments Download
src/gtest/gtest-message.h View 1 4 chunks +8 lines, -8 lines 0 comments Download
src/gtest/internal/gtest-internal.h View 1 2 chunks +4 lines, -4 lines 1 comment Download
src/gtest/internal/gtest-port.h View 1 3 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 3
Travis
14 years, 4 months ago (2008-09-25 01:30:23 UTC) #1
Travis
Same changes, but might fix problem where side-by-side diffs didn't work
14 years, 4 months ago (2008-09-25 23:25:11 UTC) #2
Travis
14 years, 4 months ago (2008-09-26 00:39:14 UTC) #3
http://codereview.appspot.com/6051/diff/212/25
File src/gtest/internal/gtest-internal.h (right):

http://codereview.appspot.com/6051/diff/212/25#newcode216
Line 216: // const T& and const T* in a function template. If the compilers
_can_
The "If" is a typo and should be removed: s/If the/The/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b