Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1269)

Issue 60500043: Fixes to get tavern.dart library working in Spark.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by pajamallama
Modified:
10 years, 2 months ago
Reviewers:
tapted
CC:
chrome-apps-internsyd_google.com
Base URL:
https://github.com/tapted/bleeding_edge.git@system_cache_location
Visibility:
Public.

Description

Fixes to get tavern.dart library working in Spark. Also added a system to the JS logging such that messages will be buffered during the log window initialization phase.

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fixed inside Spark (mainly log window JS code) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -18 lines) Patch
M dart/sdk/lib/_internal/pub/lib/src/log.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M dart/sdk/lib/_internal/pub/lib/tavern.dart View 2 chunks +10 lines, -8 lines 0 comments Download
M dart/sdk/lib/_internal/pub/lib/tavern_log.js View 1 1 chunk +42 lines, -6 lines 0 comments Download
M dart/sdk/lib/_internal/pub/manifest.json View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4
pajamallama
I shouldn't be making this many CLs on 2nd last day haha. Probz going to ...
10 years, 2 months ago (2014-02-06 04:56:09 UTC) #1
tapted
https://codereview.appspot.com/60500043/diff/1/dart/sdk/lib/_internal/pub/lib/tavern.dart File dart/sdk/lib/_internal/pub/lib/tavern.dart (right): https://codereview.appspot.com/60500043/diff/1/dart/sdk/lib/_internal/pub/lib/tavern.dart#newcode27 dart/sdk/lib/_internal/pub/lib/tavern.dart:27: return IO.loadCacheDirectory() is `IO` defined here yet? I think ...
10 years, 2 months ago (2014-02-06 05:04:57 UTC) #2
tapted
https://codereview.appspot.com/60500043/diff/1/dart/sdk/lib/_internal/pub/lib/tavern_log.js File dart/sdk/lib/_internal/pub/lib/tavern_log.js (right): https://codereview.appspot.com/60500043/diff/1/dart/sdk/lib/_internal/pub/lib/tavern_log.js#newcode13 dart/sdk/lib/_internal/pub/lib/tavern_log.js:13: document.createTextNode(line) + '</div>'; On 2014/02/06 05:04:58, tapted wrote: > ...
10 years, 2 months ago (2014-02-06 05:06:58 UTC) #3
pajamallama
10 years, 2 months ago (2014-02-07 05:33:14 UTC) #4

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b