Issue 6049044: store: serve 42 on specific path to run perf tests with blitz.io

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6049044: store: serve 42 on specific path to run perf tests with blitz.io

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by niemeyer

Modified:
12 years ago

Reviewers:
mp+102230

Visibility:
Public.

Description

store: serve 42 on specific path to run perf tests with blitz.io https://code.launchpad.net/~niemeyer/juju/go-store-blitz-key/+merge/102230 Requires: https://code.launchpad.net/~niemeyer/juju/go-store-stats-api/+merge/101672 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : store: serve 42 on specific path to run perf tests with blitz.io #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -0 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	store/server.go	View	1	2 chunks	+13 lines, -0 lines	0 comments	Download
M	store/server_test.go	View	1	1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rog

LGTM https://codereview.appspot.com/6049044/diff/1/store/server.go File store/server.go (right): https://codereview.appspot.com/6049044/diff/1/store/server.go#newcode168 store/server.go:168: w.Write([]byte("42")) given that this is a performance test, ...

12 years ago (2012-04-17 09:15:27 UTC) #2

fwereade

LGTM assuming slightly clearer explanation :). https://codereview.appspot.com/6049044/diff/1/store/server.go File store/server.go (right): https://codereview.appspot.com/6049044/diff/1/store/server.go#newcode36 store/server.go:36: // This is ...

12 years ago (2012-04-17 13:53:32 UTC) #3

niemeyer

12 years ago (2012-04-17 18:55:44 UTC) #4

*** Submitted:

store: serve 42 on specific path to run perf tests with blitz.io

R=rog, fwereade
CC=
https://codereview.appspot.com/6049044

Expand All Messages | Collapse All Messages