Issue 60340043: Changed the documention to be relevant to Tavern.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 60340043: Changed the documention to be relevant to Tavern. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by pajamallama

Modified:
10 years, 2 months ago

Reviewers:
tapted

CC:
chrome-apps-internsyd_google.com

Base URL:
https://github.com/tapted/pub-dartlang.git@master

Visibility:
Public.

More Reviews

Description

Changed the documention to be relevant to Tavern. Recompiled the CSS from mustache files so that 'Tavern' is displayed instead of pub in most locations. Updated the help pages to remove unapplicable 'pub <x>' targets. Updated help pages to show how to upload using pub. NOTE: Readded the deleted files and migrated to https://codereview.appspot.com/56910048 (Rietveld fail).

Patch Set 1 #

Total comments: 3

Patch Set 2 : Readded files. #

Patch Set 3 : Re-added files #

Patch Set 4 : Readding filesssssss #

Patch Set 5 : This one will work.. #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+445 lines, -839 lines)			Patch
M	Gemfile	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Gemfile.lock	View	3 chunks	+19 lines, -15 lines	0 comments	Download
A	OWNERS	View	1 chunk	+7 lines, -0 lines	0 comments	Download
	PRESUBMIT.py	View	1 chunk	+93 lines, -0 lines	0 comments	Download
M	app/doc/faq.markdown	View	6 chunks	+17 lines, -29 lines	0 comments	Download
M	app/doc/glossary.markdown	View	5 chunks	+9 lines, -48 lines	0 comments	Download
M	app/doc/index.markdown	View	11 chunks	+53 lines, -112 lines	0 comments	Download
M	app/doc/package-layout.markdown	View	10 chunks	+9 lines, -50 lines	0 comments	Download
	app/doc/pub-get.markdown	View	5 chunks	+32 lines, -43 lines	0 comments	Download
M	app/doc/pub-lish.markdown	View	1 chunk	+8 lines, -85 lines	0 comments	Download
	app/doc/pubspec.markdown	View	5 chunks	+13 lines, -14 lines	0 comments	Download
M	app/doc/versioning.markdown	View	7 chunks	+14 lines, -14 lines	0 comments	Download
M	app/views/doc/faq.html	View	4 chunks	+20 lines, -32 lines	0 comments	Download
M	app/views/doc/glossary.html	View	5 chunks	+12 lines, -54 lines	0 comments	Download
	app/views/doc/index.html	View	11 chunks	+53 lines, -114 lines	0 comments	Download
M	app/views/doc/package-layout.html	View	10 chunks	+9 lines, -51 lines	0 comments	Download
M	app/views/doc/pub-get.html	View	5 chunks	+29 lines, -43 lines	0 comments	Download
M	app/views/doc/pub-lish.html	View	1 chunk	+7 lines, -89 lines	0 comments	Download
M	app/views/doc/pubspec.html	View	4 chunks	+20 lines, -18 lines	0 comments	Download
M	app/views/doc/versioning.html	View	7 chunks	+14 lines, -14 lines	0 comments	Download
M	app/views/index.mustache	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	app/views/layout.mustache	View	2 chunks	+3 lines, -8 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

tapted

10 years, 2 months ago (2014-02-05 04:37:24 UTC) #2

actually, it's probably not worth fixing the nits here, but it would be good if
the change didn't delete any (whole) files, to trim the diff down a bit.

https://codereview.appspot.com/60340043/diff/1/app/doc/faq.markdown
File app/doc/faq.markdown (right):

https://codereview.appspot.com/60340043/diff/1/app/doc/faq.markdown#newcode108
app/doc/faq.markdown:108: We don't generally make public roadmaps for Tavern.
The Dart project is very fluid
nit: wrapping

https://codereview.appspot.com/60340043/diff/1/app/doc/index.markdown
File app/doc/index.markdown (right):

https://codereview.appspot.com/60340043/diff/1/app/doc/index.markdown#newcode43
app/doc/index.markdown:43: ## Installing and configuring tavern
nit: tavern -> Tavern

https://codereview.appspot.com/60340043/diff/1/app/doc/package-layout.markdown
File app/doc/package-layout.markdown (right):

https://codereview.appspot.com/60340043/diff/1/app/doc/package-layout.markdow...
app/doc/package-layout.markdown:23: When you build a Tavern package, we have a
set of conventions we encourage you to
nit: wrapping

Expand All Messages | Collapse All Messages