First attempt based on the X11 one, close to what you had in mind? https://codereview.appspot.com/60230043/diff/1/.gitattributes File .gitattributes (left): https://codereview.appspot.com/60230043/diff/1/.gitattributes#oldcode1 .gitattributes:1: * text=auto (i got many warning: LF will be replaced by CRLF in tests/preprocessor_tests/operator_test.cpp. The file will have its original line endings in your working directory. with this and upload hangs.. not sure why, but obviously won't commit)
We've actually moved our code review process over to gerrit, as it integrates better with the git workflow: https://chromium-review.googlesource.com/#/ (see https://code.google.com/p/angleproject/wiki/ContributingCode for a walkthrough of the process). https://codereview.appspot.com/60230043/diff/1/extensions/EGL_EXT_platform_an... File extensions/EGL_EXT_platform_angle_d3d.txt (right): https://codereview.appspot.com/60230043/diff/1/extensions/EGL_EXT_platform_an... extensions/EGL_EXT_platform_angle_d3d.txt:12: Scott Graham <scottmg@chromium.org> Contributors are usually listed just as "Firstname Lastname, Company", and the contact as "Firstname Lastname, Company (username 'at' company.com)" -- the platform extensions I pointed you at aren't following the usual pattern. (Sorry about that.) https://codereview.appspot.com/60230043/diff/1/extensions/EGL_EXT_platform_an... extensions/EGL_EXT_platform_angle_d3d.txt:62: EGL_PLATFORM_ANGLE_D3D_EXT 0x31D9 XXX These enum values are from Mesa's reserved range. 0x3201-0x320F is the ANGLE reserved range, so we should use values from there. https://codereview.appspot.com/60230043/diff/1/extensions/EGL_EXT_platform_an... extensions/EGL_EXT_platform_angle_d3d.txt:86: - 2 for D3D11 WARP. I think it would be better to define specific enum tokens for these values, rather than have sentinel values. (Although we could potentially exhaust those quickly.)
On 2014/02/05 01:18:26, Shannon Woods wrote: > We've actually moved our code review process over to gerrit, as it integrates > better with the git workflow: https://chromium-review.googlesource.com/#/ (see > https://code.google.com/p/angleproject/wiki/ContributingCode for a walkthrough > of the process). > > https://codereview.appspot.com/60230043/diff/1/extensions/EGL_EXT_platform_an... > File extensions/EGL_EXT_platform_angle_d3d.txt (right): > > https://codereview.appspot.com/60230043/diff/1/extensions/EGL_EXT_platform_an... > extensions/EGL_EXT_platform_angle_d3d.txt:12: Scott Graham > <mailto:scottmg@chromium.org> > Contributors are usually listed just as "Firstname Lastname, Company", and the > contact as "Firstname Lastname, Company (username 'at' company.com)" -- the > platform extensions I pointed you at aren't following the usual pattern. (Sorry > about that.) > > https://codereview.appspot.com/60230043/diff/1/extensions/EGL_EXT_platform_an... > extensions/EGL_EXT_platform_angle_d3d.txt:62: EGL_PLATFORM_ANGLE_D3D_EXT > 0x31D9 XXX > These enum values are from Mesa's reserved range. 0x3201-0x320F is the ANGLE > reserved range, so we should use values from there. > > https://codereview.appspot.com/60230043/diff/1/extensions/EGL_EXT_platform_an... > extensions/EGL_EXT_platform_angle_d3d.txt:86: - 2 for D3D11 WARP. > I think it would be better to define specific enum tokens for these values, > rather than have sentinel values. (Although we could potentially exhaust those > quickly.) (Also, I think we've generally used our google email addresses for the purposes of contact info on Khronos extensions.)
Thanks, moved here https://chromium-review.googlesource.com/#/c/184975/