Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1528)

Issue 60200043: Pointing to tapted's machine instead of pajamallama's. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by pajamallama
Modified:
10 years, 2 months ago
Reviewers:
tapted
CC:
chrome-apps-internsyd_google.com
Base URL:
https://github.com/tapted/bleeding_edge.git@master
Visibility:
Public.

Description

Pointing to tapted's machine instead of pajamallama's. Updating default host URL to tapted-z620-l.syd.corp.google.com as the previous server will be shut down in a few days. R=tapted@chromium.org Committed: https://github.com/tapted/bleeding_edge/commit/793e8e2

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updating version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M dart/sdk/lib/_internal/pub/lib/src/source/hosted.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/sdk/lib/_internal/pub/manifest.json View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
pajamallama
10 years, 2 months ago (2014-02-04 23:12:11 UTC) #1
tapted
lgtm
10 years, 2 months ago (2014-02-04 23:59:25 UTC) #2
tapted
https://codereview.appspot.com/60200043/diff/1/dart/sdk/lib/_internal/pub/manifest.json File dart/sdk/lib/_internal/pub/manifest.json (right): https://codereview.appspot.com/60200043/diff/1/dart/sdk/lib/_internal/pub/manifest.json#newcode5 dart/sdk/lib/_internal/pub/manifest.json:5: "version": "0.2", should probably bump this too
10 years, 2 months ago (2014-02-05 00:00:08 UTC) #3
pajamallama
10 years, 2 months ago (2014-02-05 06:17:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r793e8e2 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b