Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3175)

Issue 6016047: [google/google-main] Fix regression - SUBTARGET_EXTRA_SPECS overridden by LINUX_GRTE_EXTRA_SPECS

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by shenhan
Modified:
12 years, 1 month ago
CC:
gcc-patches_gcc.gnu.org
Visibility:
Public.

Description

In linux.h, macro SUBTARGET_EXTRA_SPECS is overridden by "LINUX_GRTE_EXTRA_SPECS", so the origin content of SUBTARGET_EXTRA_SPECS never gets written into gcc spec, which causes linking failure for chrome gcc.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M gcc/config/i386/i386.h View 1 chunk +3 lines, -2 lines 0 comments Download
M gcc/config/i386/linux.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4
shenhan
Hi, the newest chrome gcc (from google-main) fails to linking anything, by looking into specs ...
12 years, 2 months ago (2012-04-12 21:14:29 UTC) #1
shenhan
On 2012/04/12 21:14:29, shenhan wrote: > Hi, the newest chrome gcc (from google-main) fails to ...
12 years, 1 month ago (2012-05-14 18:32:17 UTC) #2
jingyu
I suspect this patch would change specs of non-i386 platform. For example, LINUX_GRTE_EXTRA_SPECS is not ...
12 years, 1 month ago (2012-05-15 22:26:23 UTC) #3
shenhan
12 years, 1 month ago (2012-05-16 17:16:14 UTC) #4
Hi Jing, thanks!

The SUBTARGET_EXTRA_SPECS is defined in config/i386/gnu-user.h
In "linux.h", the original value of "SUBTARGET_EXTRA_SPECS" is
overwritten by LINUX_GRTE_EXTRA_SPECS, which is not right! Instead,
"SUBTARGET_EXTRA_SPECS" and "LINUX_GRTE_EXTRA_SPECS" must be
concatenated.

For every target, "SUBTARET_EXTRA_SPECS" has its own value, for
example, for darwin, darwin.h just redefines SUBTARGET_EXTRA_SPECS, so
the patch does not affect targets other than i386.

Regards,
-Han

On Tue, May 15, 2012 at 3:26 PM, <jingyu@google.com> wrote:
>
> I suspect this patch would change specs of non-i386 platform. For
> example, LINUX_GRTE_EXTRA_SPECS is not part of SUBTARGET_EXTRA_SPECS for
> darwin.
>
> Can you tell where SUBTARGET_EXTRA_SPECS is firstly defined for chromeos
> toolchain?
>
>
>
>
> On 2012/05/14 18:32:17, shenhan wrote:
>>
>> On 2012/04/12 21:14:29, shenhan wrote:
>> > Hi, the newest chrome gcc (from google-main) fails to linking
>
> anything, by
>>
>> > looking into specs file, it seems that 'link_emulation' section is
>
> missing in
>>
>> > specs.
>> >
>> > The problem I found is that SUBTARGET_EXTRA_SPECS, which is not
>
> empty for
>>
>> > chromeos, is overridden by "LINUX_GRTE_EXTRA_SPECS".
>> >
>> > Please review the proposed a patch. (Tested by buildit bootstrap).
>> >
>> > -Han
>
>
>> Hi Jing and Rong, could you take a look at this?
>
>
>> Thanks,
>> -Han
>
>
>
>
> http://codereview.appspot.com/6016047/




--
Han Shen |  Software Engineer |  shenhan@google.com |  +1-650-440-3330
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b