Issue 60130043: Add support for cached fonts

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 60130043: Add support for cached fonts

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by gary.poster

Modified:
10 years, 2 months ago

Reviewers:
bac, mp+204772

Visibility:
Public.

Description

Add support for cached fonts Per https://launchpad.net/bugs/1274955 , and building off recently landed work in the GUI itself (https://github.com/juju/juju-gui/pull/104), this adds configuration to support cached fonts. To QA, deploy the charm with GUI trunk as you wish, and then verify in your browser's inspector's network tab that the font CSS is being downloaded from Google. Then set cached-fonts to true (command line or GUI), wait about ten seconds, do a hard reload on the GUI, and you should see in the network tab that there is no CSS from Google anymore, and there is now a fontface.css delivered locally. To deploy the charm with GUI trunk, I like to `git pull juju develop` in my GUI trunk, `make clean && make distfile`, copy the release into the charm's releases directory, `juju switch local`, `juju bootstrap`, and `make deploy` in the charm. YMMV: the other option instead of the `make distfile` approach is to use `juju set juju-gui juju-gui-source=develop`. https://code.launchpad.net/~gary/charms/precise/juju-gui/cachedFonts/+merge/204772 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Add support for cached fonts #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -3 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	config.yaml	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	config/config.js.template	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	hooks/backend.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	hooks/utils.py	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	tests/test_backends.py	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	tests/test_utils.py	View	2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gary.poster

10 years, 2 months ago (2014-02-04 21:29:26 UTC) #4

*** Submitted:

Add support for cached fonts

Per https://launchpad.net/bugs/1274955 , and building off recently landed work
in the GUI itself (https://github.com/juju/juju-gui/pull/104), this adds
configuration to support cached fonts.

To QA, deploy the charm with GUI trunk as you wish, and then verify in your
browser's inspector's network tab that the font CSS is being downloaded from
Google.  Then set cached-fonts to true (command line or GUI), wait about ten
seconds, do a hard reload on the GUI, and you should see in the network tab that
there is no CSS from Google anymore, and there is now a fontface.css delivered
locally.

To deploy the charm with GUI trunk, I like to `git pull juju develop` in my GUI
trunk, `make clean && make distfile`, copy the release into the charm's releases
directory, `juju switch local`, `juju bootstrap`, and `make deploy` in the
charm.  YMMV: the other option instead of the `make distfile` approach is to use
`juju set juju-gui juju-gui-source=develop`.

R=bac
CC=
https://codereview.appspot.com/60130043

Expand All Messages | Collapse All Messages