Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14729)

Issue 6012045: orchestra provider now respects ubuntu-series constraint

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by fwereade
Modified:
12 years ago
Reviewers:
mp+101670
Visibility:
Public.

Description

orchestra provider now respects ubuntu-series constraint This is done by setting a new system profile before powering on the machine; and assumes that the Cobbler system profiles created as part of the ubuntu-orchestra-server install actually exist. Anecdotal evidence suggests that people really don't mess with the distros and profiles available (they just set up their systems and go) and so I consider the impact of this drawback to be extremely limited. Furthermore, while it is possible to extract real arch and series info from cobbler (ie we can get a system's arch from its profile's distro, and we can partially match new profiles by checking the distro's series and arch) this is not enough to select an actual profile without depending on some convention: we either have to infer the presence of the juju preseed from the profile name (as I do currently) or to check the profile itself for a magic string (ie the path to the juju preseed). So: we depend on orchestra install conventions, whatever we do; and IMO it's cleanest and simplest to actually embrace that and save all the mucking about with distros and profiles. https://code.launchpad.net/~fwereade/juju/orchestra-series-constraints/+merge/101670 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : orchestra provider now respects ubuntu-series constraint #

Patch Set 3 : orchestra provider now respects ubuntu-series constraint #

Patch Set 4 : orchestra provider now respects ubuntu-series constraint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -25 lines) Patch
A [revision details] View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M juju/providers/orchestra/cobbler.py View 4 chunks +31 lines, -5 lines 0 comments Download
M juju/providers/orchestra/launch.py View 2 chunks +2 lines, -1 line 0 comments Download
M juju/providers/orchestra/tests/common.py View 3 chunks +9 lines, -2 lines 0 comments Download
M juju/providers/orchestra/tests/data/bootstrap_user_data View 1 chunk +1 line, -1 line 0 comments Download
M juju/providers/orchestra/tests/test_bootstrap.py View 5 chunks +10 lines, -7 lines 0 comments Download
M juju/providers/orchestra/tests/test_cobbler.py View 11 chunks +57 lines, -4 lines 0 comments Download
M juju/providers/orchestra/tests/test_launch.py View 4 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 5
fwereade
Please take a look.
12 years ago (2012-04-12 01:14:36 UTC) #1
fwereade
Please take a look.
12 years ago (2012-04-12 01:25:54 UTC) #2
fwereade
Please take a look.
12 years ago (2012-04-12 01:31:09 UTC) #3
hazmat
lgtm
12 years ago (2012-04-12 17:59:20 UTC) #4
fwereade
12 years ago (2012-04-12 18:57:38 UTC) #5
*** Submitted:

orchestra provider now respects ubuntu-series constraint

This is done by setting a new system profile before powering on the machine;
and assumes that the Cobbler system profiles created as part of the
ubuntu-orchestra-server install actually exist. Anecdotal evidence suggests
that people really don't mess with the distros and profiles available (they
just set up their systems and go) and so I consider the impact of this
drawback to be extremely limited.

Furthermore, while it is possible to extract real arch and series info from
cobbler (ie we can get a system's arch from its profile's distro, and we can
partially match new profiles by checking the distro's series and arch) this
is not enough to select an actual profile without depending on some
convention: we either have to infer the presence of the juju preseed from
the profile name (as I do currently) or to check the profile itself for
a magic string (ie the path to the juju preseed).

So: we depend on orchestra install conventions, whatever we do; and IMO it's
cleanest and simplest to actually embrace that and save all the mucking
about with distros and profiles.

R=hazmat
CC=
https://codereview.appspot.com/6012045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b