store: don't add unknown tokens to db when summing stats

store: don't add unknown tokens to db when summing stats



https://code.launchpad.net/~niemeyer/juju/go-store-stats-readonly/+merge/101673

Requires: https://code.launchpad.net/~niemeyer/juju/go-store-stats/+merge/101442

(do not edit description out of merge proposal)

[niemeyer, 2012-04-12 02:06:19]

Please take a look.

[niemeyer, 2012-04-12 02:15:55]

Please take a look.

[niemeyer, 2012-04-16 23:57:39]

Please take a look.

[fwereade, 2012-04-17 13:12:45]

LGTM

[rog, 2012-04-17 13:26:32]

LGTM

https://codereview.appspot.com/6009047/diff/5001/store/store.go
File store/store.go (right):

https://codereview.appspot.com/6009047/diff/5001/store/store.go#newcode105
store/store.go:105: // the key content and size from the actual words used in
key.
// If write is true, the key will be created if necessary.

or alternatively, since all the language around the CL and the tests is talking
about read-onlyness, you could invert the bool and use "read".

// If read is true, the key will returned only if
// it has already been created.

[niemeyer, 2012-04-17 17:25:52]

*** Submitted:

store: don't add unknown tokens to db when summing stats

R=fwereade, rog
CC=
https://codereview.appspot.com/6009047

https://codereview.appspot.com/6009047/diff/5001/store/store.go
File store/store.go (right):

https://codereview.appspot.com/6009047/diff/5001/store/store.go#newcode105
store/store.go:105: // the key content and size from the actual words used in
key.
On 2012/04/17 13:26:33, rog wrote:
> // If write is true, the key will be created if necessary.
> 
> or alternatively, since all the language around the CL and the tests is
talking
> about read-onlyness, you could invert the bool and use "read".
> 
> // If read is true, the key will returned only if
> // it has already been created.

Done.