Issue 60070044: code review 60070044: bench: move benchmarks from other repo

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 60070044: code review 60070044: bench: move benchmarks from other repo (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by dvyukov

Modified:
2 weeks, 6 days ago

Reviewers:
adg, fundasecgin33

CC:
adg, golang-codereviews

Visibility:
Public.

Description

bench: move benchmarks from other repo No code changes. Dir structure is changed. I think it's mostly TBR, but if you want to take the final look.

Patch Set 1 #

Patch Set 2 : diff -r f1a14a701f91 https://code.google.com/p/go.benchmarks #

Patch Set 3 : diff -r f1a14a701f91 https://code.google.com/p/go.benchmarks #

Patch Set 4 : diff -r f1a14a701f91 https://code.google.com/p/go.benchmarks #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2853 lines, -0 lines)			Patch
A	bench/bench.go	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
A	build/build.go	View	1	1 chunk	+84 lines, -0 lines	0 comments	Download
A	driver/driver.go	View	1	1 chunk	+401 lines, -0 lines	0 comments	Download
A	driver/driver_darwin.go	View	1	1 chunk	+48 lines, -0 lines	0 comments	Download
A	driver/driver_freebsd.go	View	1	1 chunk	+23 lines, -0 lines	0 comments	Download
A	driver/driver_go10.go	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download
A	driver/driver_go12.go	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download
A	driver/driver_linux.go	View	1	1 chunk	+158 lines, -0 lines	0 comments	Download
A	driver/driver_unix.go	View	1	1 chunk	+62 lines, -0 lines	0 comments	Download
A	driver/driver_windows.go	View	1	1 chunk	+140 lines, -0 lines	0 comments	Download
A	json/json.go	View	1	1 chunk	+79 lines, -0 lines	0 comments	Download
A	json/json_data.go	View	1	1 chunk	+1810 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dvyukov

Hello adg@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.benchmarks

11 years ago (2014-02-05 18:21:26 UTC) #1

dvyukov

*** Submitted as https://code.google.com/p/go/source/detail?r=f2c11d87b6d3&repo=benchmarks *** bench: move benchmarks from other repo No code changes. Dir ...

11 years ago (2014-02-10 15:22:54 UTC) #3

Message was sent while issue was closed.

Expand All Messages | Collapse All Messages