Issue 6005046: orchestra-classes now prevents use of internal mgmt-classes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6005046: orchestra-classes now prevents use of internal mgmt-classes

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by fwereade

Modified:
12 years ago

Reviewers:
mp+101505

Visibility:
Public.

Description

orchestra-classes now prevents use of internal mgmt-classes https://code.launchpad.net/~fwereade/juju/check-orchestra-classes/+merge/101505 (do not edit description out of merge proposal)

Patch Set 2 : orchestra-classes now prevents use of internal mgmt-classes #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -5 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	juju/providers/orchestra/__init__.py	View	1	2 chunks	+22 lines, -3 lines	0 comments	Download
M	juju/providers/orchestra/tests/test_provider.py	View	1	3 chunks	+35 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

hazmat

looks good https://codereview.appspot.com/6005046/diff/1/juju/providers/orchestra/__init__.py File juju/providers/orchestra/__init__.py (right): https://codereview.appspot.com/6005046/diff/1/juju/providers/orchestra/__init__.py#newcode38 juju/providers/orchestra/__init__.py:38: mgmt_classes = filter(None, s.split(",")) don't these also ...

12 years ago (2012-04-11 12:48:44 UTC) #2

fwereade

12 years ago (2012-04-11 13:41:00 UTC) #3

*** Submitted:

orchestra-classes now prevents use of internal mgmt-classes

R=hazmat
CC=
https://codereview.appspot.com/6005046

https://codereview.appspot.com/6005046/diff/1/juju/providers/orchestra/__init...
File juju/providers/orchestra/__init__.py (right):

https://codereview.appspot.com/6005046/diff/1/juju/providers/orchestra/__init...
juju/providers/orchestra/__init__.py:38: mgmt_classes = filter(None,
s.split(","))
On 2012/04/11 12:48:44, hazmat wrote:
> don't these also need to be stripped? ie.
> 
> >> "1,  2, 3,4".split(",")
> ['1', '  2', ' 3', '4']

Can't hurt. Done

https://codereview.appspot.com/6005046/diff/1/juju/providers/orchestra/tests/...
File juju/providers/orchestra/tests/test_provider.py (right):

https://codereview.appspot.com/6005046/diff/1/juju/providers/orchestra/tests/...
juju/providers/orchestra/tests/test_provider.py:123: def
test_satsify_constraints(self):
On 2012/04/11 12:48:44, hazmat wrote:
> speling

Done.

Expand All Messages | Collapse All Messages