Issue 6001050: Forward-compatibility fixes for Constraints

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6001050: Forward-compatibility fixes for Constraints

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by fwereade

Modified:
12 years ago

Reviewers:
mp+101560

Visibility:
Public.

Description

Forward-compatibility fixes for Constraints * Any constraint name can now be registered; no more global registry * Unrecognised constraints are now ignored but persisted when introduced via ConstraintSet.load * Unrecognised traits are now always errors when introduced via ConstraintSet.parse https://code.launchpad.net/~fwereade/juju/constraints-compatibility/+merge/101560 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Forward-compatibility fixes for Constraints #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -79 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	juju/machine/constraints.py	View	5 chunks	+7 lines, -33 lines	0 comments	Download
M	juju/machine/tests/test_constraints.py	View	5 chunks	+18 lines, -46 lines	0 comments	Download
M	juju/providers/common/tests/test_launch.py	View	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fwereade

12 years ago (2012-04-11 15:44:03 UTC) #3

*** Submitted:

Forward-compatibility fixes for Constraints

* Any constraint name can now be registered; no more global registry
* Unrecognised constraints are now ignored but persisted when introduced via
  ConstraintSet.load
* Unrecognised traits are now always errors when introduced via
  ConstraintSet.parse

R=hazmat
CC=
https://codereview.appspot.com/6001050

Expand All Messages | Collapse All Messages