Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2069)

Issue 59930043: Add errgo as a dep, and start using it.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by thumper
Modified:
10 years, 2 months ago
Reviewers:
mp+204604, william.reade, rog
Visibility:
Public.

Description

Add errgo as a dep, and start using it. errgo adds the ability to capture the location of the error creation or annotation. Annotated errors don't lose the original error. https://code.launchpad.net/~thumper/juju-core/use-errgo/+merge/204604 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -77 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M agent/agent.go View 6 chunks +11 lines, -10 lines 0 comments Download
M agent/tools/toolsdir.go View 2 chunks +3 lines, -1 line 0 comments Download
M cert/cert.go View 2 chunks +4 lines, -2 lines 0 comments Download
M cmd/juju/bootstrap.go View 2 chunks +2 lines, -1 line 0 comments Download
M constraints/constraints.go View 2 chunks +3 lines, -1 line 0 comments Download
M dependencies.tsv View 1 chunk +1 line, -0 lines 0 comments Download
A dependencies_test.go View 1 chunk +42 lines, -0 lines 1 comment Download
M environs/cloudinit.go View 2 chunks +3 lines, -1 line 0 comments Download
M environs/cloudinit/cloudinit.go View 4 chunks +4 lines, -3 lines 0 comments Download
M environs/config/config.go View 2 chunks +2 lines, -1 line 0 comments Download
M environs/configstore/disk.go View 3 chunks +5 lines, -4 lines 0 comments Download
M environs/open.go View 2 chunks +3 lines, -1 line 0 comments Download
M state/apiserver/charms.go View 4 chunks +19 lines, -17 lines 0 comments Download
M state/apiserver/client/client.go View 3 chunks +12 lines, -11 lines 0 comments Download
M worker/firewaller/firewaller.go View 21 chunks +25 lines, -24 lines 0 comments Download

Messages

Total messages: 3
thumper
Please take a look.
10 years, 2 months ago (2014-02-04 06:38:32 UTC) #1
william.reade
LGTM
10 years, 2 months ago (2014-02-04 07:46:29 UTC) #2
rog
10 years, 2 months ago (2014-02-04 13:56:12 UTC) #3
https://codereview.appspot.com/59930043/diff/1/dependencies_test.go
File dependencies_test.go (right):

https://codereview.appspot.com/59930043/diff/1/dependencies_test.go#newcode30
dependencies_test.go:30: func (*dependenciesTest) TestDependenciesTsvFormat(c
*gc.C) {
I think this would work work better as a test in .lbox.check.
There is no package in the root directory and this doesn't really seem like a
great reason to create one.

awk -F "\t" 'NF != 4 {exit 1}' || {
    echo dependencies.tsv is in an invalid format >&2
    exit 1
}

would do the job.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b