Issue 5991058: relation-ids should default to $JUJU_RELATION

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5991058: relation-ids should default to $JUJU_RELATION

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by jimbaker

Modified:
12 years ago

Reviewers:
mp+101156, hazmat

Visibility:
Public.

Description

relation-ids should default to $JUJU_RELATION If no relation name is specified for the relation-ids hook command, it should default to $JUJU_RELATION. If that's not available, it should raise an error stating "Relation name must be specified". https://code.launchpad.net/~jimbaker/juju/must-specify-relation-name/+merge/101156 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : relation-ids should default to $JUJU_RELATION #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -11 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	juju/hooks/commands.py	View	1	2 chunks	+11 lines, -3 lines	0 comments	Download
M	juju/hooks/protocol.py	View		2 chunks	+16 lines, -2 lines	0 comments	Download
M	juju/hooks/tests/test_communications.py	View		3 chunks	+16 lines, -2 lines	0 comments	Download
M	juju/hooks/tests/test_invoker.py	View	1	3 chunks	+29 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

hazmat

This is almost a trivial branch.. but.. its a bit odd that this bothers to ...

12 years ago (2012-04-10 14:09:06 UTC) #2

I have added this check on the client side.

Expand All Messages | Collapse All Messages