Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8607)

Issue 5991047: code review 5991047: runtime: minor refactoring in preparation for parallel GC (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by dvyukov
Modified:
10 years, 8 months ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

runtime: minor refactoring in preparation for parallel GC factor sweepspan() out of sweep(), no logical changes

Patch Set 1 #

Patch Set 2 : diff -r 56758af2b1e4 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 56758af2b1e4 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 4db68027d900 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 4db68027d900 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r dd0b27040a5a https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -65 lines) Patch
M src/pkg/runtime/mgc0.c View 1 2 3 4 5 2 chunks +73 lines, -65 lines 0 comments Download

Messages

Total messages: 7
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 8 months ago (2012-04-05 16:19:50 UTC) #1
rsc
Please put sweepspan after sweep instead of before it, so that the code continues to ...
10 years, 8 months ago (2012-04-05 16:38:22 UTC) #2
dvyukov
Hello golang-dev@googlegroups.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 8 months ago (2012-04-05 16:43:45 UTC) #3
dvyukov
On 2012/04/05 16:38:22, rsc wrote: > Please put sweepspan after sweep instead of before it, ...
10 years, 8 months ago (2012-04-05 16:44:33 UTC) #4
rsc
LGTM
10 years, 8 months ago (2012-04-05 16:53:38 UTC) #5
dvyukov
*** Submitted as http://code.google.com/p/go/source/detail?r=0b2d96522c1f *** runtime: minor refactoring in preparation for parallel GC factor sweepspan() ...
10 years, 8 months ago (2012-04-05 17:02:42 UTC) #6
dvyukov
10 years, 8 months ago (2012-04-05 19:10:18 UTC) #7
On Apr 5, 2012 8:38 PM, "Russ Cox" <rsc@golang.org> wrote:
>
> Please put sweepspan after sweep instead of before it,
> so that the code continues to read from top-to-bottom.

I like the top-to-bottom feature of Go

> It will require a forward declaration, but that's just the way
> C is.  It should also make the diffs much smaller.
>
> Thanks.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b