Issue 5989050: managed zk connections for transient and session failures.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5989050: managed zk connections for transient and session failures.

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by hazmat

Modified:
12 years ago

Reviewers:
mp+101132, fwereade

Visibility:
Public.

Description

managed zk connections for transient and session failures. This branch switches agents to use managed session clients which automatically retry in the face of transient disconnections, and automatically restablish session on expiration (with watch and ephemeral node handling). https://code.launchpad.net/~hazmat/juju/managed-zk-client/+merge/101132 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -26 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	juju/agents/base.py	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	juju/charm/tests/test_publisher.py	View	3 chunks	+1 line, -3 lines	0 comments	Download
M	juju/lib/testing.py	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	juju/providers/dummy.py	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	juju/providers/local/__init__.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	juju/state/tests/common.py	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	juju/state/tests/test_base.py	View	4 chunks	+3 lines, -5 lines	0 comments	Download
M	juju/state/tests/test_initialize.py	View	3 chunks	+1 line, -3 lines	0 comments	Download
M	juju/state/tests/test_relation.py	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	juju/state/tests/test_utils.py	View	5 chunks	+3 lines, -6 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

fwereade

12 years ago (2012-04-11 13:38:12 UTC) #2

LGTM

I retain some misgivings about making this change at this late stage, but this
change and the txzookeeper one both appear to be entirely sane. I think we're
good :).

Expand All Messages | Collapse All Messages