Added ErrDying. Renamed ErrStillRunning to ErrStillAlive.

Added ErrDying. Renamed ErrStillRunning to ErrStillAlive.



https://code.launchpad.net/~niemeyer/tomb/err-dying/+merge/100662

(do not edit description out of merge proposal)

[niemeyer, 2012-04-03 17:57:01]

Please take a look.

[TheMue, 2012-04-03 18:25:21]

Changes are fine, only minor comments to already existing code.

https://codereview.appspot.com/5981052/diff/1/tomb.go
File tomb.go (right):

https://codereview.appspot.com/5981052/diff/1/tomb.go#newcode84
tomb.go:84: t.m.Unlock()
Why don't you defer t.m.Unlock() immediately after t.m.Lock()?

https://codereview.appspot.com/5981052/diff/1/tomb.go#newcode148
tomb.go:148: t.m.Unlock()
Againg a defer would put Lock() and Unlock() together, line 131 could be removed
and the statement t.reason == ErrStillAlive could move into the if statement.

https://codereview.appspot.com/5981052/diff/1/tomb.go#newcode165
tomb.go:165: t.m.Unlock()
Like above:

t.init()
t.m.Lock()
defer t.m.Unlock()

return t.reason

[niemeyer, 2012-04-03 18:52:31]

https://codereview.appspot.com/5981052/diff/1/tomb.go
File tomb.go (right):

https://codereview.appspot.com/5981052/diff/1/tomb.go#newcode84
tomb.go:84: t.m.Unlock()
On 2012/04/03 18:25:21, TheMue wrote:
> Why don't you defer t.m.Unlock() immediately after t.m.Lock()?

Because these are assignments. defer is unnecessary overhead here.

https://codereview.appspot.com/5981052/diff/1/tomb.go#newcode148
tomb.go:148: t.m.Unlock()
On 2012/04/03 18:25:21, TheMue wrote:
> Againg a defer would put Lock() and Unlock() together, line 131 could be
removed
> and the statement t.reason == ErrStillAlive could move into the if statement.

Sounds good.

https://codereview.appspot.com/5981052/diff/1/tomb.go#newcode165
tomb.go:165: t.m.Unlock()
On 2012/04/03 18:25:21, TheMue wrote:
> Like above:
> 
> t.init()
> t.m.Lock()
> defer t.m.Unlock()
> return t.reason

That's an assignment. Defer is unnecessary overhead here.

[niemeyer, 2012-04-03 18:56:48]

Please take a look.

[TheMue, 2012-04-03 18:58:48]

LGTM

On 2012/04/03 18:56:48, niemeyer wrote:
> Please take a look.

[niemeyer, 2012-04-03 19:47:15]

*** Submitted:

Added ErrDying. Renamed ErrStillRunning to ErrStillAlive.

R=TheMue
CC=
https://codereview.appspot.com/5981052