Issue 5980045: When extracting charms, use only filetype mode bits to detect symlinkicity

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5980045: When extracting charms, use only filetype mode bits to detect symlinkicity

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by fwereade

Modified:
12 years, 1 month ago

Reviewers:
mp+100769

Visibility:
Public.

Description

When extracting charms, use only filetype mode bits to detect symlinkicity We had been writing, and checking for, a magic value (in external_attr) which happened to equal `(stat.S_IFLNK | 0755) << 16`; the charm store was giving us one equal to `(stat.S_IFLNK | 0777) << 16`, and we weren't considering that to be a symlink. We now just check the filetype and ignore permissions on symlinks. https://code.launchpad.net/~fwereade/juju/fix-charm-symlinks/+merge/100769 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : When extracting charms, use only filetype mode bits to detect symlinkicity #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -11 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	juju/charm/base.py	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	juju/charm/bundle.py	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	juju/charm/directory.py	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	juju/charm/tests/test_bundle.py	View	2 chunks	+29 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fwereade

12 years, 1 month ago (2012-04-04 12:30:32 UTC) #3

*** Submitted:

When extracting charms, use only filetype mode bits to detect symlinkicity

We had been writing, and checking for, a magic value (in external_attr)
which happened to equal `(stat.S_IFLNK | 0755) << 16`; the charm store was
giving us one equal to `(stat.S_IFLNK | 0777) << 16`, and we weren't
considering that to be a symlink. We now just check the filetype and ignore
permissions on symlinks.

R=hazmat
CC=
https://codereview.appspot.com/5980045

Expand All Messages | Collapse All Messages