Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(328)

Issue 5976055: Changes .tex files to get rid of warning (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 2 months ago by PhilEHolmes
Modified:
7 years, 2 months ago
Reviewers:
Graham Percival, email, dak, Julien Rioux
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

These files used what appears to be a deprecated syntax to invoke lilypond-book, resulting in these warnings: lilypond-book.py: warning: deprecated ly-option used: 11pt=None lilypond-book.py: warning: compatibility mode translation: staffsize=11 Applying these changes gets rid of those errors in make doc.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -25 lines) Patch
Documentation/usage/latex-lilypond-example.latex View 2 chunks +14 lines, -14 lines 0 comments Download
M input/regression/lilypond-book/tex-comments.lytex View 1 chunk +1 line, -1 line 0 comments Download
M input/regression/lilypond-book/tex-compatibility-mode.lytex View 1 chunk +1 line, -1 line 0 comments Download
M input/regression/lilypond-book/tex-lilypond-inside-itemize.lytex View 1 chunk +5 lines, -5 lines 0 comments Download
M input/regression/lilypond-book/tex-lilypond-inside-table.lytex View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7
PhilEHolmes
Please review
7 years, 2 months ago (2012-04-01 12:32:26 UTC) #1
Graham Percival
The .latex file just says "upload in progress". Could you add it to the exceptions ...
7 years, 2 months ago (2012-04-01 13:23:05 UTC) #2
email_philholmes.net
----- Original Message ----- From: <graham@percival-music.ca> To: <PhilEHolmes@googlemail.com>; <julien.rioux@gmail.com>; <dak@gnu.org> Cc: <lilypond-devel@gnu.org>; <reply@codereview-hr.appspotmail.com> Sent: Sunday, ...
7 years, 2 months ago (2012-04-01 14:16:57 UTC) #3
Graham Percival
On Sun, Apr 01, 2012 at 03:16:52PM +0100, Phil Holmes wrote: > It looked fine ...
7 years, 2 months ago (2012-04-01 16:09:53 UTC) #4
Julien Rioux
On Sun, Apr 1, 2012 at 2:32 PM, <PhilEHolmes@googlemail.com> wrote: > Reviewers: Julien Rioux, Graham ...
7 years, 2 months ago (2012-04-02 08:12:40 UTC) #5
email_philholmes.net
----- Original Message ----- From: "Julien Rioux" <julien.rioux@gmail.com> To: <PhilEHolmes@googlemail.com>; <julien.rioux@gmail.com>; <graham@percival-music.ca>; <dak@gnu.org>; <lilypond-devel@gnu.org>; <reply@codereview-hr.appspotmail.com> ...
7 years, 2 months ago (2012-04-02 09:11:08 UTC) #6
Julien Rioux
7 years, 2 months ago (2012-04-02 10:22:57 UTC) #7
On Mon, Apr 2, 2012 at 11:11 AM, Phil Holmes <email@philholmes.net> wrote:
> ----- Original Message ----- From: "Julien Rioux" <julien.rioux@gmail.com>
> To: <PhilEHolmes@googlemail.com>; <julien.rioux@gmail.com>;
> <graham@percival-music.ca>; <dak@gnu.org>; <lilypond-devel@gnu.org>;
> <reply@codereview-hr.appspotmail.com>
>
>> > A snippet with a deprecated option, triggering compatibility mode:
>> >
>> > -\lilypond[11pt,fragment]{c' e' g'}
>> > +\lilypond[staffsize=11,fragment]{c' e' g'}
>> >
>> > \end{document}
>>
>> This change to tex-compatibility-mode.tex makes no sense. The whole
>> point of this file is to test that deprecated options are still
>> supported.
>> --
>> Julien
>
>
> Excellent catch - thanks, Julien.  I was in auto-correct mode.  How do you
> suggest we correct this?  I doubt we want this warning displayed.
> run-and-check?
>
> --
> Phil Holmes
>
>

Yes I think run-and-check is fine for this.
--
Julien
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b