Issue 59740050: code review 59740050: os/exec: use filepath.Base in Command

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 59740050: code review 59740050: os/exec: use filepath.Base in Command (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by brainman

Modified:
11 years, 5 months ago

Reviewers:
iant, bradfitz

CC:
golang-codereviews, iant, bradfitz

Visibility:
Public.

Description

os/exec: use filepath.Base in Command filepath.Base covers all scenarios (for example paths like d:hello.txt) on windows

Patch Set 1 #

Patch Set 2 : diff -r ae14bde9ce3c https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r ae14bde9ce3c https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 093db14aee5e https://go.googlecode.com/hg/ #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -11 lines)			Patch
	M	src/pkg/go/build/deps_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	src/pkg/os/exec/exec.go	View	1	3 chunks	+2 lines, -10 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

brainman

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 5 months ago (2014-02-06 05:26:32 UTC) #1

brainman

11 years, 5 months ago (2014-02-07 01:30:37 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=a5b451d7be59 ***

os/exec: use filepath.Base in Command

filepath.Base covers all scenarios
(for example paths like d:hello.txt)
on windows

LGTM=iant, bradfitz
R=golang-codereviews, iant, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/59740050

Expand All Messages | Collapse All Messages