Issue 5967064: store: config file for commands to avoid disclosing passwords

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5967064: store: config file for commands to avoid disclosing passwords

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by niemeyer

Modified:
12 years ago

Reviewers:
mp+100445

Visibility:
Public.

Description

store: config file for commands to avoid disclosing passwords Some minimum duplication was now introduced across both charmd and charmload. If the trend continues, we have to refactor both of them into a single command with two subcommands, and back them by the juju/go/cmd infrastructure. https://code.launchpad.net/~niemeyer/juju/go-store-cmds-config/+merge/100445 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : store: config file for commands to avoid disclosing passwords #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+87 lines, -11 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	store/charmd/config.yaml	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	store/charmd/main.go	View	3 chunks	+41 lines, -7 lines	0 comments	Download
A	store/charmload/config.yaml	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	store/charmload/main.go	View	2 chunks	+41 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

niemeyer

12 years ago (2012-04-02 15:19:36 UTC) #2

*** Submitted:

store: config file for commands to avoid disclosing passwords

Some minimum duplication was now introduced across both
charmd and charmload. If the trend continues, we have to
refactor both of them into a single command with two
subcommands, and back them by the juju/go/cmd infrastructure.

R=
CC=
https://codereview.appspot.com/5967064

Expand All Messages | Collapse All Messages