Issue 59620043: ec2: Fixed #1275406 - LocalServerSuite failure

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 59620043: ec2: Fixed #1275406 - LocalServerSuite failure (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by dimitern

Modified:
10 years, 2 months ago

Reviewers:
gz, mp+204469, rog

Visibility:
Public.

Description

ec2: Fixed #1275406 - LocalServerSuite failure LocalServerSuite.TestInstanceInfo fails due to the DNSName field being empty, where as the test expect it populated. Changed the test to refresh the instance data after it's started, because DNSName is empty until the instance state is "started" (according to AWS docs). In the test suite this is simulated by getting the instance data again, which includes the populated DNSName. https://code.launchpad.net/~dimitern/goamz/lp-1275406-lpcalserversuite-testinstanceinfo/+merge/204469 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : ec2: Fixed #1275406 - LocalServerSuite failure #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	ec2/ec2t_test.go	View		1 chunk	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

rog

On 2014/02/03 12:13:15, dimitern wrote: > Please take a look. LGTM

10 years, 2 months ago (2014-02-06 11:34:11 UTC) #2

Fun. This is my test, added at r40, and it passes there. Wonder what broke ...

10 years, 2 months ago (2014-02-06 16:12:37 UTC) #3

niemeyer

On 2014/02/07 13:24:51, dimitern wrote: > Thanks for all the reviews guys! You've been added ...

10 years, 2 months ago (2014-02-12 12:53:53 UTC) #5

dimitern

On 2014/02/12 12:53:53, niemeyer wrote: > On 2014/02/07 13:24:51, dimitern wrote: > > Thanks for ...

10 years, 2 months ago (2014-02-12 12:59:22 UTC) #6

dimitern

10 years, 2 months ago (2014-02-12 13:02:32 UTC) #7

*** Submitted:

ec2: Fixed #1275406 - LocalServerSuite failure

LocalServerSuite.TestInstanceInfo fails due to
the DNSName field being empty, where as the
test expect it populated.
Changed the test to refresh the instance data
after it's started, because DNSName is empty
until the instance state is "started" (according
to AWS docs). In the test suite this is simulated
by getting the instance data again, which includes
the populated DNSName.

R=rog, gz, niemeyer
CC=
https://codereview.appspot.com/59620043

Expand All Messages | Collapse All Messages