Issue 5958045: store: add server Connection and Content-Length headers

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5958045: store: add server Connection and Content-Length headers

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by niemeyer

Modified:
12 years, 1 month ago

Reviewers:
mp+99869, rog

Visibility:
Public.

Description

store: add server Connection and Content-Length headers Also redirect / to juju.ubuntu.com. https://code.launchpad.net/~niemeyer/juju/go-store-more-headers/+merge/99869 Requires: https://code.launchpad.net/~niemeyer/juju/go-store-info-size/+merge/99862 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : store: add server Connection and Content-Length headers #

Total comments: 2

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -1 line)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	store/server.go	View	4 chunks	+8 lines, -1 line	2 comments	Download
M	store/server_test.go	View	2 chunks	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

niemeyer

*** Submitted: store: add server Connection and Content-Length headers Also redirect / to juju.ubuntu.com. R= ...

12 years, 1 month ago (2012-03-29 05:03:01 UTC) #2

rog

LGTM https://codereview.appspot.com/5958045/diff/3001/store/server.go File store/server.go (right): https://codereview.appspot.com/5958045/diff/3001/store/server.go#newcode108 store/server.go:108: w.Header().Set("Connection", "close") // No keep-alive for now. why?

12 years, 1 month ago (2012-03-29 10:40:51 UTC) #3

niemeyer

12 years, 1 month ago (2012-03-29 14:05:28 UTC) #4

https://codereview.appspot.com/5958045/diff/3001/store/server.go
File store/server.go (right):

https://codereview.appspot.com/5958045/diff/3001/store/server.go#newcode108
store/server.go:108: w.Header().Set("Connection", "close") // No keep-alive for
now.
On 2012/03/29 10:40:51, rog wrote:
> why?

Nagios is having trouble with connections kept alive. I'll investigate this
further and this will possibly change in our side soon, but for now this should
solve the problem to get it deployed.

Expand All Messages | Collapse All Messages