Issue 59580045: code review 59580045: runtime: fix build on freebsd/arm

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 59580045: code review 59580045: runtime: fix build on freebsd/arm (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by mikio

Modified:
11 years, 5 months ago

Reviewers:
minux1, iant

CC:
iant, minux1, dave_cheney.net, golang-codereviews

Visibility:
Public.

Description

runtime: fix build on freebsd/arm This CL is in preparation to make cgo work on freebsd/arm. How to generate defs-files on freebsd/arm in the bootstrapping phase: 1. run freebsd on appropriate arm-eabi platforms 2. both syscall z-files and runtime def-files in the current tree are broken about EABI padding, fix them by hand 3. run make.bash again to build $GOTOOLDIR/cgo 4. use $GOTOOLDIR/cgo directly

Patch Set 1 : diff -r ae14bde9ce3c https://code.google.com/p/go #

Patch Set 2 : diff -r ae14bde9ce3c https://code.google.com/p/go #

Patch Set 3 : diff -r 9623db1cea87 https://code.google.com/p/go #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -14 lines)			Patch
	M	src/pkg/runtime/defs_freebsd_arm.h	View		4 chunks	+16 lines, -14 lines	0 comments	Download

Messages

Total messages: 8

Expand All Messages | Collapse All Messages

mikio

Hello iant@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 5 months ago (2014-02-06 06:04:22 UTC) #1

iant

Please update the CL description to say how you generated the file. Thanks.

11 years, 5 months ago (2014-02-06 06:08:56 UTC) #2

dave_cheney.net

I'm trying again right now. If others have a working FreeBSD system, please consider running ...

11 years, 5 months ago (2014-02-06 06:37:17 UTC) #6

mikio

11 years, 5 months ago (2014-02-07 01:22:20 UTC) #8

*** Submitted as https://code.google.com/p/go/source/detail?r=895aa9ad802a ***

runtime: fix build on freebsd/arm

This CL is in preparation to make cgo work on freebsd/arm.

How to generate defs-files on freebsd/arm in the bootstrapping phase:
1. run freebsd on appropriate arm-eabi platforms
2. both syscall z-files and runtime def-files in the current tree are
   broken about EABI padding, fix them by hand
3. run make.bash again to build $GOTOOLDIR/cgo
4. use $GOTOOLDIR/cgo directly

LGTM=minux.ma, iant
R=iant, minux.ma, dave
CC=golang-codereviews
https://codereview.appspot.com/59580045

Expand All Messages | Collapse All Messages