ConstraintSet.parse now logs on ignored constraints

ConstraintSet.parse now logs on ignored constraints



https://code.launchpad.net/~fwereade/juju/warn-ignored-constraints/+merge/99861

Requires: https://code.launchpad.net/~fwereade/juju/block-legacy-constraints-usage/+merge/99856

(do not edit description out of merge proposal)

[fwereade, 2012-03-29 03:45:49]

Please take a look.

[fwereade, 2012-03-29 11:32:49]

Please take a look.

[hazmat, 2012-03-29 19:59:55]

one minor on distinguishing warning context, else LGTM

https://codereview.appspot.com/5956044/diff/3001/juju/machine/constraints.py
File juju/machine/constraints.py (right):

https://codereview.appspot.com/5956044/diff/3001/juju/machine/constraints.py#...
juju/machine/constraints.py:172: "ignored irrelevant %r constraint", name)
The distinction between irrelevant (not applicable to the current provider) and
invalid (non existent) seems a bit muddled here. afaics this is passed values
straight from the cli, so fat fingering a instance-typo would be better to err,
as opposed to setting deploying a service with local provider and instance-type.

[fwereade, 2012-03-30 08:33:04]

https://codereview.appspot.com/5956044/diff/3001/juju/machine/constraints.py
File juju/machine/constraints.py (right):

https://codereview.appspot.com/5956044/diff/3001/juju/machine/constraints.py#...
juju/machine/constraints.py:172: "ignored irrelevant %r constraint", name)
On 2012/03/29 19:59:55, hazmat wrote:
> The distinction between irrelevant (not applicable to the current provider)
and
> invalid (non existent) seems a bit muddled here. afaics this is passed values
> straight from the cli, so fat fingering a instance-typo would be better to
err,
> as opposed to setting deploying a service with local provider and
instance-type.
> 

"instance-type=m1.small" will warn in a non-ec2 provider;
"instance-typo=m1.small" will error in every provider.

[fwereade, 2012-03-30 08:41:58]

https://codereview.appspot.com/5956044/diff/3001/juju/machine/constraints.py
File juju/machine/constraints.py (right):

https://codereview.appspot.com/5956044/diff/3001/juju/machine/constraints.py#...
juju/machine/constraints.py:172: "ignored irrelevant %r constraint", name)
On 2012/03/30 08:33:05, fwereade wrote:
> On 2012/03/29 19:59:55, hazmat wrote:
> > The distinction between irrelevant (not applicable to the current provider)
> and
> > invalid (non existent) seems a bit muddled here. afaics this is passed
values
> > straight from the cli, so fat fingering a instance-typo would be better to
> err,
> > as opposed to setting deploying a service with local provider and
> instance-type.
> > 
> 
> "instance-type=m1.small" will warn in a non-ec2 provider;
> "instance-typo=m1.small" will error in every provider.

(I added an explanatory comment all the same, it was clearly unclear as it
stood.)

[fwereade, 2012-03-30 09:39:54]

*** Submitted:

ConstraintSet.parse now logs on ignored constraints

R=hazmat
CC=
https://codereview.appspot.com/5956044